Add immutable_account_mutated dylint detector#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
immutable_account_mutatedas a dylint detector (extension/detectors/immutable_account_mutated/) usingLateLintPassHIR analysisImmutableAccountMutatedDetectorfrom the language server registry (replaced by the dylint version)DiagnosticRelatedInformationsupport to the dylint diagnostic pipeline — detectors can now emit bidirectional navigation links (e.g., mutation site ↔ field declaration)Detection strategy
The lint checks public functions with
Context<T>parameters, resolves the Accounts structT, identifies fields of typeAccount/AccountInfo/AccountLoaderwithout#[account(mut)]or#[account(init)], and walks the function body for mutations (assignments, compound assignments,&mutborrows, mutating method calls). Emits warnings on both the mutation site and the field declaration with clickable cross-references.