Conversation
Follow-up to Ackites#127: resolve vendor ROM slot-to-subscription mappings and use the effective Android 16 temporary override path.
Resolve vendor slot-to-subscription mappings through the existing Shizuku channel and use the effective Android 16 override path.
Pass the active application context through the carrier override UI calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nThis is a follow-up to #127 for devices where Nrfr reports a successful save but the target service still sees the original carrier config.\n\n- ignore SubscriptionManager.INVALID_SUBSCRIPTION_ID instead of using -1 as a real target\n- resolve slot-to-subscription IDs through dumpsys isub over the existing Shizuku channel when the legacy API returns an invalid value\n- use the effective non-persistent override path on Android 16 (API 36), while retaining persistent behavior on older releases\n- keep the Android 16 instrumentation fallback from #122/#127\n\n## Validation\n\n- Redmi K80 / HyperOS / Android 16 / Shizuku\n- before: save UI reported success, but logs showed Invalid phoneId: -1 and no effective override\n- after: slot 0 resolved to subId=1; mOverrideConfigs contained sim_country_iso_override_string=us and carrier_name_string=T-Mobile USA; TikTok loaded the feed after restart\n\nThe local build check reached dependency resolution, but Maven Central returned HTTP 403 for jsr305; device validation used the patched APK recorded in the local verification artifacts.