Code-walk findings: full fingerprint, honest broken-chain output, doc drift - #4
Merged
Merged
Conversation
…t on a broken chain, doc/glossary drift W1: verify prints the FULL key fingerprint in the checklist line (the out-of-band comparison needs the whole value; a truncated prefix leaves room for a collided key). The verdict rung stays short. W2: a broken chain means there is no evidence index - the archive is now reported as 'not judged', not accused of smuggling file by file. W3: VERIFICATION-TRAIL.md guarantee tier 3 no longer says anchoring is 'deliberately deferred' - the seals section built today closes it; the tier now points there. W4: GLOSSARY gains Package / Manifest / Seal / Source reference / Assessment id rows; Verification trail row updated for seals. W5: CLAUDE.md module map gains seal.py and verify.py + new CLI verbs. W6: last 'audit' naming leftovers in README security line and THREAT-MODEL.md. W7: evidence archiving warns when a referenced source is missing from the snapshot instead of shipping the gap silently. W8: write_report comment updated to the consistency-not-provenance wording (the docs moved; the comment had not). 70 tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Acquiredl
added a commit
that referenced
this pull request
Aug 26, 2026
Code-walk findings: full fingerprint, honest broken-chain output, doc drift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the 2026-08-25 provenance-arc code walk (walk #2). W1: verify prints the full key fingerprint in the checklist (a truncated prefix leaves collision room; the verdict rung stays short). W2: a broken chain no longer accuses archive files of being unreferenced — the chain is the index and it is unusable, so the archive is reported as not judged. W3: guarantee tier 3 no longer says anchoring is deferred (the seals section closes it). W4: glossary rows for Package / Manifest / Seal / Source reference / Assessment id. W5: CLAUDE.md module map gains seal.py, verify.py and the new CLI verbs. W6: last audit-naming strays in README and THREAT-MODEL. W7: evidence archiver warns on an unarchivable source reference instead of shipping the gap silently. W8: write_report comment de-drifted. 70 tests green.
🤖 Generated with Claude Code