feat: always-active-pattern in canonical queries #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 34e6452 in 1 minute and 11 seconds. Click for details.
- Reviewed
44lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. aw_client/classes.py:73
- Draft comment:
Clarify the server fetch comment. The note on prod vs test server is ambiguous. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. aw_client/queries.py:59
- Draft comment:
Add a brief comment explaining the purpose of 'always_active_pattern'. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_UpPm8vrrKWcLjnma
You can customize 
aw_client/queries.py
Outdated
| not_afk = filter_keyvals(not_afk, "status", ["not-afk"]);""" | ||
| + ( | ||
| f""" | ||
| not_treat_as_afk = filter_keyvals_regex(events, "app", "{params.always_active_pattern}"); |
There was a problem hiding this comment.
Ensure 'always_active_pattern' is sanitized/escaped to prevent regex injection since it's inserted directly into the query.
0xbrayo
force-pushed
the
always-active-pattern
branch
from
34e6452 to
74d187f
Compare
feat:escape quotes in always-active-pattern
0xbrayo
force-pushed
the
always-active-pattern
branch
from
74d187f to
00d90cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds
always_active_patterntoDesktopQueryParamsand updatescanonicalEvents()to handle always-active applications inqueries.py.always_active_patterntoDesktopQueryParamsinqueries.pyto handle always-active applications.canonicalEvents()inqueries.pyto includealways_active_patterninnot_afkevent processing.get_classes()inclasses.py.This description was created by
for 34e6452. You can customize this summary. It will automatically update as commits are pushed.