Fix headline bug and add image support#5
Open
Astrian wants to merge 4 commits intoActuallyTaylor:mainfrom
Open
Fix headline bug and add image support#5Astrian wants to merge 4 commits intoActuallyTaylor:mainfrom
Astrian wants to merge 4 commits intoActuallyTaylor:mainfrom
Conversation
The headline may render to the same line to the last paragraph
Owner
|
Thank you for making this PR! What are the changes to the Headers? I am seeing tests for those failing so I am wondering if the tests are incorrect because output was originally flawed. |
Author
ActuallyTaylor
requested changes
Feb 5, 2026
Owner
ActuallyTaylor
left a comment
There was a problem hiding this comment.
Once the tests are passing this will be good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

\n\nbefore the headline so that the headline may be rendered to the last paragraphBTW. The Xcode 16.0 reports an error indicating that the
firstMatch(in: _)function may not be available in lower than iOS 16 (Sources/SwiftHTMLtoMarkdown/BasicHTML.swift:98). I have no idea if it is a critical issue because I have no errors encountered when I use this library with network reference. The error appears when I clone the library to the local and import it as a local library.Here is a suggested fix authored by Xcode: