Skip to content

refacto: sever inky-rb upstream link#10

Merged
PhilMeyr merged 1 commit into
masterfrom
refacto/detach-upstream
Jul 1, 2026
Merged

refacto: sever inky-rb upstream link#10
PhilMeyr merged 1 commit into
masterfrom
refacto/detach-upstream

Conversation

@PhilMeyr

@PhilMeyr PhilMeyr commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Contexte

activemail est un fork modernisé de foundation/inky-rb (ZURB, non maintenu). Le renommage principal était déjà fait ; cette PR sévère les attaches résiduelles à l'upstream sans réécrire l'historique ni casser l'API publique (extension .inky et tag <inky> conservés délibérément).

Changements

  • Remote git upstream retiré (côté local, git remote remove upstream).
  • Inky-isme interne renommé : ActiveMail::Core#release_the_kraken#transpile, tous les appelants mis à jour (template handler, tests, doc).
  • Fixtures neutralisées : http://zurb.comhttps://example.com (button/menu tests).
  • README : mention « fork of inky-rb » retirée de l'intro ; note discrète conservant l'attribution ZURB dans la section License.
  • Version 1.2.0 → 1.2.1 + entrée CHANGELOG.

Conservé délibérément

  • Extension .inky/.inky-erb + tag <inky> + classe Inky (convention de balisage de la gem, pas une fuite upstream).
  • Copyright ZURB dans LICENSE.txt — requis par la licence MIT, ne peut pas être supprimé.

⚠️ Action manuelle requise (hors code)

Le lien de fork GitHub (badge « forked from foundation/inky-rb ») ne se retire pas via git. Un admin doit, dans Settings du repo, utiliser « Leave fork network » si disponible, sinon ouvrir un ticket GitHub Support « Detach a fork ».

Vérification

  • bundle exec rake test → 297 runs, 0 failures.
  • bundle exec srb tc → No errors.
  • bundle exec rubocop lib test → no offenses.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d25fc75edd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@PhilMeyr
PhilMeyr merged commit a750e94 into master Jul 1, 2026
11 of 12 checks passed
@PhilMeyr
PhilMeyr deleted the refacto/detach-upstream branch July 1, 2026 12:56
@AdVitam AdVitam deleted a comment from chatgpt-codex-connector Bot Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant