Scissors - Stella #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaddox19
reviewed
May 25, 2021
jmaddox19
left a comment
jmaddox19
left a comment
There was a problem hiding this comment.
Code is very clean and readable! Just one little suggestion for improvement I've been offering people.
| completed_at = db.Column(db.DateTime) | ||
| goal_id = db.Column(db.Integer, db.ForeignKey('goal.goal_id'), nullable=True) | ||
|
|
||
| def task_response(self): |
| response = {"task":task.task_response()} | ||
| return jsonify(response), 200 | ||
|
|
||
| def slack_message(task): |
There was a problem hiding this comment.
Cool that this is it's own function! I think it makes the rest of the code more readable
|
|
||
| response = {} | ||
| response["id"] = int(goal_id) | ||
| response["task_ids"] = request_body["task_ids"] |
There was a problem hiding this comment.
This change would have made the above-mentioned bug more obvious. This would also allow the response to include ALL tasks associated with the goal, not just the new ones.
This isn't super intuitive so I'd definitely be down to talk through this more in our next 1:1
Suggested change
| response["task_ids"] = request_body["task_ids"] | |
| full_task_ids = [] | |
| for task in goal.tasks: | |
| full_task_ids.append(task.task_id) | |
| response["task_ids"] = full_task_ids |
Comment on lines
+195
to
+206
| goal = Goal.query.get(goal_id) | ||
|
|
||
| goal_task_response = [] | ||
|
|
||
| for task in goal.tasks: | ||
| goal_task_response.append(task.task_response()) | ||
|
|
||
| response = { | ||
| "id": goal.goal_id, | ||
| "title": goal.title, | ||
| "tasks": goal_task_response | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.