Conversation
|
update: Python version of the data ouput program is committed. |
|
and the interactive one :) |
poverty_info.rb
Outdated
| @@ -0,0 +1,47 @@ | |||
| require 'pry' | |||
There was a problem hiding this comment.
Super nitpick but try to get in the hang of removing any remnants of your debugging process when you submit your PRs
|
Updates look good! |
|
I just committed some java. So far, I've succeeded at outputting the first line of each of the text files. Wondering if you have any feedback as I continue. |
| private static final Map<String, String> stateFiles; | ||
| static | ||
| { | ||
| stateFiles = new HashMap<String, String>(); |
There was a problem hiding this comment.
HashMap works here, might recommend using the Dictionary instead
|
Updated with Java! I have two programs, corresponding to the two programs that I wrote in Ruby and Python. |
|
|
||
| public class GetPovertyInfo { | ||
|
|
||
| public static String getMatch(String county) throws FileNotFoundException { |
There was a problem hiding this comment.
I like that you added the throws here. I would say it is more typical to put a try and catch around the block of code than to put the throws at the method level.
|
|
I have two programs in Ruby- one for outputting data (for Washington and South Dakota), and one that takes user input for counties in Washington. These are pretty basic, and I could do more with it, but I thought they were a decent baseline that I can start translating to Python. Glad to take any feedback before I start doing that.