When gprbuild checks for ar & nm, they are not found on the aarch64 linux distros.#26
Open
bib1963 wants to merge 1 commit intoAdaCore:masterfrom
Open
When gprbuild checks for ar & nm, they are not found on the aarch64 linux distros.#26bib1963 wants to merge 1 commit intoAdaCore:masterfrom
bib1963 wants to merge 1 commit intoAdaCore:masterfrom
Conversation
however, they are not found on aarch64, and so, no static libraries are created. ar & lm on Linux distros are checked on the expression 'aarch64-linux-gnu' or 'x86_64.*-linux.*'. As shown, the search on aarch64 is absolute compared to x86_64. This change modifies the aarch expression to be 'aarch64(-.*)?-linux(-gnu)?$' This allows for a distros name & the '-gnu' part to be wholly optional and as such will trigger on a target name of 'aarch64-suse-linux'. This is more strict than the x86_64 expression & so is more unlikely to be fired for other names. Perhaps the x86_64 expression should be updated to somewhat mirror this aarch64 change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When gprbuild checks for ar & nm, these are found on the x86_64 systems,
however, they are not found on aarch64, and so, no static libraries are created.
ar & lm on Linux distros are checked on the expression 'aarch64-linux-gnu' or 'x86_64.-linux.'.
As shown, the search on aarch64 is absolute compared to x86_64.
This change modifies the aarch expression to be 'aarch64(-.*)?-linux(-gnu)?$'
This allows for a distros name & the '-gnu' part to be wholly optional and as such will trigger on a target name of 'aarch64-suse-linux'.
This is more strict than the x86_64 expression & so is more unlikely to be fired for other names. Perhaps the x86_64 expression should be updated to somewhat mirror this aarch64 change.