render-askama: render_class_with_methods_wide — the WideFieldMask entry#163
Merged
Conversation
…ry (bake gap F1) The single missing function the render-bake design named: the narrow entry loud-fails any >64-field class under a partial mask (work_packages ~109 cols — the exact class lance-graph #651 minted WideFieldMask for). Additive sibling entry taking &WideFieldMask (not Copy — Box past 64 bits); the shared ctx build is factored into a private render_class_with_methods_via(class, field_present: impl Fn(u8)->bool, actions) — zero behavior change to the narrow entry, its u64 guard byte-identical (regression-pinned). Tests: partial wide mask gates exact fields on an 80/70-field class; full_for emits all; narrow class byte-identical through both entries; narrow entry still loud-fails >64 while wide succeeds on the same class. Crate suite green; clippy --all-targets -D warnings clean. No new deps (WideFieldMask was already reachable via the existing lance-graph-contract dep). Built by a Sonnet grindwork agent under fixed spec; orchestrator-verified.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_0c3173a2-9e69-483c-ad1f-49ba7baf77c1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The single gap the render-bake design named (F1):
render_class_with_methodsis u64-only and loud-fails any >64-field class under a partial mask —work_packages(~109 cols) is exactly the class lance-graph #651 mintedWideFieldMaskfor.Additive sibling entry
render_class_with_methods_wide(&Class, &WideFieldMask, &[ActionDef]); shared ctx build factored into a private presence-closure helper — the narrow entry's semantics and its >64 guard are byte-identical (regression-pinned by test). No template change, no new deps (WideFieldMaskwas already reachable via the existing lance-graph-contract dep).Tests: partial wide mask gates exact fields on an 80/70-field class;
full_foremits all; narrow class byte-identical through both entries; narrow entry still loud-fails while wide succeeds on the same class. Crate suite green; clippy-D warningsclean.Consumer: op-nexgen's render-bake probe (OP leg wide classes); downstream
odoo-rs#23 already wiredMaskWords → WideFieldMask.🤖 Generated with Claude Code