registration: close the three arago config-parity gaps at the instanc…#184
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7e6fd9d7-f00a-4031-89c6-b04fef76545d) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9914fbba2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .map(|p| ActionParam { | ||
| name: p.name.clone(), | ||
| mandatory: false, | ||
| default: Some(p.value.clone()), |
There was a problem hiding this comment.
When a dispatcher follows the new contract and appends these params to the capability signature, bind_parameters checks request-supplied values before defaults, so representing Applicability.Parameter{Name,Value} as an optional ActionParam lets any submitAction include the same name and replace the configured injection. For the documented SSH SshOpts case, that means a caller can strip or change the operator-provided BatchMode/StrictHostKeyChecking options instead of receiving the fixed applicability value that arago config declares.
Useful? React with 👍 / 👎.
…e lift
Ground-truth re-check of ARAGO-ACTIONHANDLER-PARITY.md §1 against the
actual AdaWorldAPI/ActionHandlers repo (the ssh_based_actions aae.yaml
stanza) found two unlisted gaps plus the known footnote-² one. All three
close additively at the B2-lift, verbatim-value tested:
- Applicability.Parameter{Name,Value} (the SshOpts pattern): new
ApplicabilityParam + RegisteredApplicability::parameters, lifted to
bindable ActionParam{mandatory:false, default:Some(value)} via
lift_applicability_full / lift_applicabilities_full /
parse_applicabilities_full — bind_parameters reproduces arago's
template injection.
- Per-param Description: the DTO carried it, lift_capability dropped it
— now ConcreteCapability::param_descriptions (kept OFF ActionParam:
binding needs (name,mandatory,default) only; doc metadata rides the
lift artifact, not the IR type).
- Applicability.Priority: RegisteredApplicability::priority +
ConcreteApplicability::priority.
Guard-only views (lift_applicabilities / parse_applicabilities) and the
schema-level ApplicabilitySlot are untouched — the ontology genuinely
does not declare deploy-config fields. Ledger: DISCOVERY-MAP
D-ACTIONHANDLER-GROUNDTRUTH-GAPS-CLOSED; parity doc §7 addendum (incl.
two fidelity notes: config-YAML nests the filter under Var:, and
Mode:string is a match-type discriminator).
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EZ7GvnCGsZTqAZXUxwWfdh
AdaWorldAPI
force-pushed
the
claude/bardioc-parity-check-0vz7sd
branch
from
b9914fb to
825bc28
Compare
2 participants
…e lift
Ground-truth re-check of ARAGO-ACTIONHANDLER-PARITY.md §1 against the actual AdaWorldAPI/ActionHandlers repo (the ssh_based_actions aae.yaml stanza) found two unlisted gaps plus the known footnote-² one. All three close additively at the B2-lift, verbatim-value tested:
Guard-only views (lift_applicabilities / parse_applicabilities) and the schema-level ApplicabilitySlot are untouched — the ontology genuinely does not declare deploy-config fields. Ledger: DISCOVERY-MAP D-ACTIONHANDLER-GROUNDTRUTH-GAPS-CLOSED; parity doc §7 addendum (incl. two fidelity notes: config-YAML nests the filter under Var:, and Mode:string is a match-type discriminator).
Claude-Session: https://claude.ai/code/session_01EZ7GvnCGsZTqAZXUxwWfdh