feat(od-ontology): od-codegen --actions — operator inspection of the behavioral lowering#10
Merged
Merged
Conversation
…behavioral lowering Mirrors the --classids flag for the behavioral arm (corpus_to_actions, #9): one `model.method <TAB> kind <TAB> detail` row per ActionDef, kind = depends|guard, respecting --focus. Lets an operator inspect the lifecycle lowering on any corpus the same way --classids exposes the classid map. $ od-codegen data/slice_2.spo.ndjson --focus account_move --actions account_move._check_expense_ids guard before_save (reject) account_move._compute_amount depends account_move.line_ids, … New `corpus_action_rows(&[Triple]) -> Vec<(model, predicate, kind, detail)>` keeps the ogar_vocab enum match INSIDE od_ontology, so the bin prints the rows without depending on ogar-vocab or matching its #[non_exhaustive] enums. The --actions arm is self-gated under ogar-emit (flag recognized without the feature; prints a rebuild directive). Verified end-to-end: 358 action rows on the full slice_2 corpus. 39 lib + 7 bin tests (incl. action_rows_format_depends_and_guard + parse_args_actions_flag), clippy 0, fmt-clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mirrors
--classidsfor the behavioral arm (corpus_to_actions, #9): a--actionsflag that prints onemodel.method <TAB> kind <TAB> detailrow perActionDef(kind = depends|guard), respecting--focus. An operator can nowinspect the lifecycle lowering on any corpus the same way
--classidsexposes the classid map.
How (keeps
ogar_vocabout of the bin)New
corpus_action_rows(&[Triple]) -> Vec<(model, predicate, kind, detail)>keeps the
ogar_vocabenum match inside od_ontology, so the bin prints rowswithout depending on
ogar-vocabor matching its#[non_exhaustive]enums. The--actionsarm self-gates underogar-emit(the flag is recognized without thefeature; prints a rebuild directive), exactly like
--classids.Verified
End-to-end: 358 action rows on the full slice-2 corpus; the focused view
above. 39 lib + 7 bin tests (incl.
action_rows_format_depends_and_guard+parse_args_actions_flag), clippy 0, fmt-clean.Closes the operator-visibility loop for the W3 behavioral arm: scope (#7) →
lowering (#9) → inspection (this). Builds on merged #9.