Skip to content

deps(od-ontology): bump ogar-vocab → 597ecb1 + tighten alignment_pin to 11-of-11 cross-axis closure#18

Merged
AdaWorldAPI merged 4 commits into
mainfrom
claude/bump-ogar-pin-tighten-cross-axis-pin-to-zero-remaining
Jun 24, 2026
Merged

deps(od-ontology): bump ogar-vocab → 597ecb1 + tighten alignment_pin to 11-of-11 cross-axis closure#18
AdaWorldAPI merged 4 commits into
mainfrom
claude/bump-ogar-pin-tighten-cross-axis-pin-to-zero-remaining

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Closes the cross-axis identity loop opened by PR #14

After OGAR #111 (PRODUCT + ACCOUNTING_ACCOUNT), #126 (PRICELIST cluster), and #127 (HR domain mint), plus lance-graph #597 / #606 / #608 mirroring each in turn, every one of the 15 seeded classes in ODOO_SEED now has a canonical OGAR class_id. The cross-axis identity gap surfaced by this crate's PR #14 is fully closed.

Two changes

1. crates/od-ontology/Cargo.toml — pin bump

- ogar-vocab = { ... rev = "ac4b4162..." }
+ ogar-vocab = { ... rev = "597ecb12..." }

Picks up:

  • OGAR #111 — PRODUCT + ACCOUNTING_ACCOUNT (0x0207 / 0x0208)
  • OGAR #126 — PRICELIST + PRICELIST_RULE + UNIT_OF_MEASURE (0x0209 / 0x020A / 0x020B)
  • OGAR #127 — HR domain mint: HR_EMPLOYEE + HR_DEPARTMENT + HR_JOB + HR_EMPLOYMENT_CONTRACT (new 0x0DXX domain — 0x0D01 / 0x0D02 / 0x0D03 / 0x0D04)
  • Plus the lance-graph-contract mirror for all of the above (lance-graph #597 / #606 / #608)

2. tests/alignment_pin.rs — tighten the hard pin

Previously: 3-class commerce-arm hard pin (res.partner, account.move, account.move.line) + informational eprintln! listing the 7 (then 11) remaining un-mapped seeded classes.

Now: all 15 seeded classes asserted to have a canonical OGAR classid. The hard assertion: assert!(without_classid.is_empty(), ...). Re-introducing any un-mapped class regresses the closure and fires the test immediately.

The test's explanatory comment block also refreshed to reflect the closed state — no more "currently covers the commerce arm only" language.

Status of the arc

Layer PR What State
OGAR #111 PRODUCT + ACCOUNTING_ACCOUNT merged
OGAR #126 PRICELIST cluster merged
OGAR #127 HR domain mint merged
lance-graph #597 (D2) mirror #111 merged
lance-graph #606 (D3) mirror #126 merged
lance-graph #608 (D4) mirror #127 + closes 11-of-11 open
odoo-rs (THIS PR) pin bump + tighten open

Tests

  • cargo test -p od-ontology --features ogar-emit alignment_pin — should pass with the tighter assert!(without_classid.is_empty(), ...) now that all 15 seeded classes resolve via OdooPort::class_id.
  • Other 130+ tests in the suite unaffected by the pin bump (pure SHA swap; deps byte-identical between the two commits as verified in the lance-graph mirror PRs).

Refs

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@AdaWorldAPI AdaWorldAPI merged commit 91f0e12 into main Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant