deps(od-ontology): bump ogar-vocab → 597ecb1 + tighten alignment_pin to 11-of-11 cross-axis closure#18
Merged
AdaWorldAPI merged 4 commits intoJun 24, 2026
Conversation
…127 HR domain mint)
…to all-15-classes — celebrates 11-of-11 closure (OGAR #111+#126+#127)
… after tightening
…ross-axis closure
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the cross-axis identity loop opened by PR #14
After OGAR #111 (PRODUCT + ACCOUNTING_ACCOUNT), #126 (PRICELIST cluster), and #127 (HR domain mint), plus lance-graph #597 / #606 / #608 mirroring each in turn, every one of the 15 seeded classes in
ODOO_SEEDnow has a canonical OGAR class_id. The cross-axis identity gap surfaced by this crate's PR #14 is fully closed.Two changes
1.
crates/od-ontology/Cargo.toml— pin bumpPicks up:
2.
tests/alignment_pin.rs— tighten the hard pinPreviously: 3-class commerce-arm hard pin (
res.partner,account.move,account.move.line) + informationaleprintln!listing the 7 (then 11) remaining un-mapped seeded classes.Now: all 15 seeded classes asserted to have a canonical OGAR classid. The hard assertion:
assert!(without_classid.is_empty(), ...). Re-introducing any un-mapped class regresses the closure and fires the test immediately.The test's explanatory comment block also refreshed to reflect the closed state — no more "currently covers the commerce arm only" language.
Status of the arc
Tests
cargo test -p od-ontology --features ogar-emit alignment_pin— should pass with the tighterassert!(without_classid.is_empty(), ...)now that all 15 seeded classes resolve viaOdooPort::class_id.Refs