get_interface_statistics: SSH counters omit cpu/vlan rows (mops/snmp n=36 vs ssh 28)

[AdamRickards]

Why

Split from #46 post-#271 prove (main 3025a12).

SSH show interface counters returns 28 physical ports. MOPS/SNMP n=36 = 28 physical + 8 cpu/*+vlan/*.

Parent #46 closed: physical SSH row-count leftover cleared.

Floor

SSH row set documents physical-only or includes cpu/vlan if a CLI show exists — without inventing.

Proof

Sidecar get_interface_statistics.read trace:true after overlay/CLI decision.

Not

• Reopening get_interface_statistics.read parity: row count: mops=36 vs ssh=1 #46 physical n=1
• utilization* snmp defaults (fix(wire): drop get_interface_statistics SNMP fanout walks (#264) #267 tradeoff)
• Device identity
• Engine park

Route

Schema/SSH overlay (Architect). From #46 split.

[AdamRickards]

Architect assign — prefer physical floor (webUI-shaped)

HITL/control for interface statistics is physical ports only (same class as Port Statistics page vs ifTable pad). cpu/vlan in mops/snmp n=36 are ifTable extras, not missing SSH cages.

Preferred soft fix: Schema index_filter (or equivalent existing tool) so get_interface_statistics keys physical ^\d+/\d+$ across protocols — SSH 28 already honest; do not invent SSH for cpu/vlan.

Alt: document SSH physical-only as intentional and close as wont-fix — only if filter is wrong for a caller.

Named proof: all protocols n=physical (28-class), no cpu/vlan rows; or NO_HOLE.

Not Engine. Not reopen #46. No device identity on GitHub.

[AdamRickards]

Decision trail (Schema clerk) — #272 get_interface_statistics physical floor

• Flow: Soft get_interface_statistics: SSH counters omit cpu/vlan rows (mops/snmp n=36 vs ssh 28) #272 post-fix(wire): SSH get_interface_statistics from show interface counters (#46) #271 (3025a12). Prefer existing method index_filter: '^\d+/\d+$' (sibling get_optics / Port Statistics–shaped physical) so mops/snmp match SSH n≈28 — or document wont-fix / NO_HOLE. Schema/wire YAML only. Author Adam. No --gate, no lab IPs, no get_optics.read parity: row count: mops=36 vs ssh=1 #55/fix(schema): get_optics keyed by detected SFP, SSH show sfp #76 optics touch, no invent SSH for cpu/vlan, not Engine, not reopen get_interface_statistics.read parity: row count: mops=36 vs ssh=1 #46.
• Classification: wont-fix / NO_HOLE (no YAML change, no-PR).

Confirm (step 1)

crude_engine/schemas/interface.yaml get_interface_statistics on main (3025a12): type: dict, primary_key: name, key_map: ifindex — no index_filter. SSH already physical-only via #271 overlay; mops/snmp remain ifTable-shaped (cpu/* + vlan/* pad → n=36).

Existing tool search (no invent)

Candidate	Verdict
Method index_filter regex (^\d+/\d+$)	Cannot apply to this method shape. Documented ingress-only (SCHEMA_PRIMITIVES.md: intent resolution / _resolve_intent; “only applies when index is a list from all expansion”). In-tree method uses: set_rstp_port, set_auto_disable, auto_disable_reset (all type: upsert).
Engine egress path	_pipeline_egress(..., index_list) never reads index_list. _shape_table_output has no index_filter — full walked ifTable rows (incl. cpu/vlan) survive key_map → human names.
Sibling get_optics index_filter	Present on a dict getter but egress-idle; physical-only there comes from walked hm2SfpDiagEntry (detected SFP), not the regex. Cargo-culting the same key onto statistics would be a silent no-op.
Attr _index_filter / SNMP index_filter dict	Targeted cell GET / compound-suffix skip — wrong tool for Port Statistics key-set shaping.
Invent SSH cpu/vlan counters	Forbidden by assign / Architect.

Read-only prove (engine honors method filter only on list indexes):

_resolve_intent: if index_filter and isinstance(index, list) → regex keep
_pipeline_egress: index_list unused in body
_shape_table_output: no index_filter

Change

None. Adding index_filter under get_interface_statistics would not change mops/snmp n=36. Do not invent Engine egress filtering on this Schema hop.

Tool run

• python3 local/generator/validate_schemas.py --errors — 0 errors (45/46 compliant; same 1 profile.yaml warning as main; 0 new; no schema edit)

Green / leftover

• Green / intentional: SSH physical-only (~28) from fix(wire): SSH get_interface_statistics from show interface counters (#46) #271 show interface counters is the honest Port Statistics–shaped floor. cpu/vlan in mops/snmp are ifTable extras, not missing SSH cages.
• NO_HOLE: Method index_filter does not filter egress dict table keys. Closing physical parity across protocols needs an Engine hop (egress honor of method index_filter after key_map, or equivalent existing primitive if one is added upstairs) — out of Schema/wire scope. Not reopen get_interface_statistics.read parity: row count: mops=36 vs ssh=1 #46. Related: get_interface_statistics: SSH counters omit cpu/vlan rows (mops/snmp n=36 vs ssh 28) #272 (and get_interface_statistics.read parity: row count: mops=36 vs ssh=1 #46 context only).

Decision: wont-fix / NO_HOLE — no-PR.

[AdamRickards]

Architect accept — NO_HOLE / park

Schema trail accepted: method `index_filter` is ingress-only; egress pipeline ignores it, so it cannot shrink mops/snmp n=36. SSH physical ~28 post-#271 is intentional.

Park: Engine egress physical-filter (or equivalent) on `hitl-engine-park.md`. Soft Schema done. Do not invent Engine from Schema hole.

Leaving issue open as park consumer until HITL opens Engine list (or closes as deferred).

[AdamRickards]

Schema — Rank1 classify pass (Σ Resolve 2026-09-25)

Classification: ENGINE NO_HOLE (no PR). Method index_filter is ingress-only, and the egress dict table ignores it. Physical-only parity across protocols needs an Engine egress physical-filter. No schema/wire primitive can shrink the mops/snmp n. NO_HOLE was already accepted on 09-13, but hitl-engine-park.md has no #272 row yet, so this is flagged to Architect to add the park row. No invented floors. #92 closed.

[AdamRickards]

Architect: Engine NO_HOLE park row is on main via #383 (2f342a6). index_filter only applies on writes, so physical-only read parity needs a read-side filter in Engine. Parked until HITL opens it.