get_rstp_port.read: SSH parse n=0 (cli listed; hang-open cleared post-#215)

[AdamRickards]

Why

Live sidecar named read get_rstp_port.read missed green.

• catalog name: get_rstp_port.read
• sidecar.head: 553ec9b1b2af0fdfd64a89e6be80be21e5507bec (main)
• HTTP: 200
• result.passed: True
• local classification error/note: n/a

Per-protocol status / open_ms / call_ms / error:

• mops: status=ok open_ms=1470 call_ms=1460 elapsed_ms=2930
• snmp: status=ok open_ms=589 call_ms=1735 elapsed_ms=2324
• ssh: status=timeout open_ms=None call_ms=None elapsed_ms=9000 error=overall deadline exceeded

parity_diffs verbatim:

[]

Disagreed field values only (keys / small scalars; huge tables truncated):

• snmp raw keys: ['True', 'False']
• mops raw keys: ['True', 'False']

Hypothesis: declared protocol(s) not ok (ssh=timeout). Open/call budget, transport, or missing wire/source — not proof of a YAML field mapping until a later overlay POST is green. timeout is budget vs wall; do not fold into --gate. This is a hypothesis, not a prescription. Do not pick a winning protocol.

Floor

A later overlay PR + sync pr + this same POST {name, trace:true} should clear this miss (empty parity_diffs, every declared protocol status==ok, passed==true) or prove it is not YAML.

Live proof stays sidecar named read. Do not run --gate.

Proof

# POST <redacted> {"name":"get_rstp_port.read","trace":true}
# expect HTTP 200, result.passed true, parity_diffs [], every protocols.*.status ok

Not this issue

• Do not pick a winning protocol. 2-of-3 is not a verdict.
• Do not run --gate.
• Do not fold this into SNMPHIOS.close() destroys pending asyncio tasks; ~2s tax hits other work in the same process (sequential or concurrent) #30 (SNMPHIOS.close() / pending-task tax).
• Do not put device IPs, credentials, or the sidecar endpoint in git.
• User-confirmed CLI is baseline when cli exists; do not auto-pick MOPS/SNMP because they agree.

[AdamRickards]

Live sidecar re-test (main @ 553ec9b, no sync / no --gate). Hypothesis only — not a verdict. 2-of-3 is not a verdict.

catalog: get_rstp_port.read
sidecar.head: sha 553ec9b1b2af0fdfd64a89e6be80be21e5507bec ref main

per-protocol

proto	status	open_ms	call_ms	elapsed_ms	error
mops	ok	1456	1186	2642	—
snmp	ok	604	1789	2393	—
ssh	timeout	null	null	9000	overall deadline exceeded

SSH CLI before timeout

no — ssh object has no raw, no trace, no CLI blob. Worker never returned parsed output or a command transcript.

Stall classification (hypothesis, not verdict)

hung open. ssh.status is timeout/error, open_ms never recorded (null), call_ms missing/null. Open did not complete before the 9s overall deadline, so the call never started. Not a parser stall (no unexpected CLI blob). Not a hung call (call never began).

Hypothesis to test (not a verdict)

Timeout may be unexpected CLI data so the worker never finished, not a dead box. mops and snmp both returned parsed RSTP-port maps (True: enabled=true, priority=128, path_cost=0, edge_port=false; False: enabled=false, same defaults). That is not a winner and 2-of-3 is not a verdict. Next probe: capture SSH session bytes / last show before the 9s deadline to distinguish a stuck open() from a CLI blob the parser never completed.

[AdamRickards]

1.17 source-data differential (dry-run)

Source review only. No live SSH/SNMP/MOPS. Trees: napalm-hios-1.17 tag v1.17.0; YAML crude_engine/schemas/rstp.yaml + wire/ssh/platform-switching.yaml; 2.0 shim __getattr__ _call (no _shape_get_rstp_port).

Protocols compared: ssh (issue labels). MOPS/SNMP appear in the sidecar dump / re-test but are not labeled here, so not compared.

Facade is HIOSDriver.get_rstp_port (hios.py:782–785). YAML method is get_rstp_port (schemas/rstp.yaml:16–28, type: dict, primary_key: enabled, key_map: ifindex). 2.0 shim _calls that method with no reshape.

---

SSH — differential (extra CLI + wrong primary_key + bound columns)

1.17 SSHHIOS.get_rstp_port (ssh_hios.py:3188–3232) issues two command families and keys by port name:

show spanning-tree mst port 0
show spanning-tree port {port}

mst port 0 table col 1/2 → fwd_states[intf]. Then one show spanning-tree port {port} per name from that table (or a single interface arg). parse_dot_keys fields: Port mode, Edge Port, Port path cost, Port priority, guards, BPDU counters. Returns {port: {enabled, state, edge_port, auto_edge, path_cost, priority, …}}.

YAML SSH overlay (wire/ssh/platform-switching.yaml:56–79) binds only:

show spanning-tree port {index}   → "Port mode" / "Edge Port" / "Port priority" / "Port path cost"

No show spanning-tree mst port 0. {index} is the ifindex expansion (key_map: ifindex), not the 1/1 token 1.17 uses. Schema method primary_key: enabled (boolean) — 1.17 keys by interface name. Method-level attributes bind only hm2agentstpportstate; defaults priority / path_cost resolve to global hm2agentstpcstbridgepriority (bridge, not port) and unbound path_cost (port cost lives on port_path_cost / hm2agentstpcstportpathcost). Extra fields in 1.17 (fwd state, auto_edge, guards, BPDU rx/tx) are not on this schema method.

Hung-open / live sidecar timeout were not re-run here.

[AdamRickards]

Identity leftover (non-unique primary_key + key_map) is the engine primitive in #130 — key by wire idx when key_map is set, matching _apply_sub_tables.

Sidecar-prove this PR before closing. SSH n=0 / hung-open is a separate leftover (#92 for timeout). Do not treat mops=snmp n=28 as a live SSH pass.

[AdamRickards]

#130 sidecar prove (merged).

Sidecar on PR #130: mops=snmp n=28 (was True/False). Identity leftover is done. SSH this pass was ok n=0 (not hung). Title leftover is still SSH / #92 — do not close.

[AdamRickards]

Description leftover after #130.

Title was ssh timeout. Body had the real leftover (raw keys: True/False). Sidecar on merged #130 is mops=snmp n=28; this pass SSH was ok n=0 (cli listed, parse leftover) not hung. Overnight hang is still #92 if it returns. Retitled so the next engine matcher rests SSH parse, not identity, and a timeout matcher does not skip it.

[AdamRickards]

Not in the SSH parse split (#132).

Rest 2026-08-31 AEST merged main c39932e: mops=snmp n=28 on GRS1042-Office-Prod (2/7 enabled=False, rest True). Identity leftover done. This pass SSH hung-open (timeout, open_ms/call_ms null, no cli) — #92 class. Leave open. Earlier pass SSH was ok n=0; hang is flaky, parse is not the remainder while the session dies.

[AdamRickards]

Decision trail — SSH timeout retest (main 0604cab)

Tool: sidecar get_rstp_port.read trace:true

Receipt:

• mops: ok n=28
• snmp: ok n=28
• ssh: timeout phase=open
• parity_diffs: none
• passed=true

Bucket: retitle/comment — identity floor already met; SSH hung-open → #92.

END: leftover / #92 class

[AdamRickards]

Decision trail — post-#215 budget re-prove (main 6724659)

Receipt: mops/snmp ok n=28; ssh status=ok but n=0 / raw={}. Hang-open cleared under new open budget.

SSH cli: show spanning-tree port {index} → Parameter parse error {index} (literal placeholder). Also runs global/port shows. Formatted gather empty.

Bucket: hold — timeout intention cleared; remain is SSH overlay/parse (n=0 with cli listed), not #92 hang. Not close.

END: leftover / SSH parse