docs(agents): park #272 egress physical-filter NO_HOLE

.gitattributes

@@ -0,0 +1,3 @@
+# YAML is the product (schema + wire). Linguist hides data languages by default.
+*.yaml linguist-detectable=true
+*.yml linguist-detectable=true

README.md

@@ -20,11 +20,13 @@ No feature-specific Python. Wire YAMLs (generated from MIB) declare device truth
 
 ## Installation
 
+Not on PyPI yet (first publish is 2.10.0). From this repo:
+
 ```
-pip install crude-engine
+pip install -e .
 ```
 
-For NAPALM integration: `pip install napalm-hios` (installs crude-engine as a dependency).
+NAPALM integration is the separate `napalm-hios` 2.0 shim — not on PyPI yet.
 
 ## Usage
 
@@ -66,7 +68,7 @@ for operation in ['create', 'read', 'upsert', 'delete', 'execute']:
 | [status.html](docs/status.html) | Program poster — where we are, next task, proofs |
 | [SEED.md](docs/program/SEED.md) | Why + how work is allowed to happen |
 | [ROADMAP.md](docs/ROADMAP.md) | Versions and exit criteria (2.10 = first PyPI) |
-| [TODO.md](docs/TODO.md) | Current cycle tasks |
+| [GitHub issues](https://github.com/AdamRickards/crude-engine/issues) | Leftover work (prove-then-file or comment-close) |
 | [METHOD_REFERENCE.md](docs/METHOD_REFERENCE.md) | Quick reference — methods, return keys, one line each |
 | [API_REFERENCE.md](docs/API_REFERENCE.md) | Full reference — return schemas, per-protocol sources, wire detail |
 | [SCHEMA_MODEL.md](docs/SCHEMA_MODEL.md) | Canonical schema contract — structural rules + shape rules |

crude_engine/drivers/SSH_state.yaml

@@ -13,6 +13,9 @@ levels:
   user:
     prompt_pattern: '[^#]>\s*$'
     exit: {command: "logout", to: null}
+    # Gate detect strings are literal prompt fragments (not regex).
+    # ssh_transport.close() re.escapes them for Netmiko read_until_pattern
+    # so "(Y/N)" matches the live logout confirm (#224 / session_log).
     gates:
       - {detect: "Are you sure (Y/N)", response: "y", read_timeout: 2}
       - {detect: "do you want to save", response: "n", read_timeout: 1}

crude_engine/drivers/base.py

@@ -1,5 +1,5 @@
 """
-base.py — Base driver interface for napalm-hios.
+base.py — Base driver interface for crude-engine.
 
 Layer: Driver (abstract). The contract between engine and transport.
 Engine calls gather() and set_values(). Driver calls transport. Nothing
@@ -72,6 +72,11 @@ def wire_type_defaults(self) -> Dict[str, str]:
         """Schema type → default tag from driver YAML."""
         return self._driver_config.get("wire_type_defaults", {})
 
+    @staticmethod
+    def _tag_name(tag):
+        """Bare registry function name from a _resolve_tag() result."""
+        return tag[0] if isinstance(tag, tuple) else tag
+
     @property
     def protocol_defaults(self) -> Dict[str, Any]:
         """Protocol-level source defaults (e.g. method: walk)."""

crude_engine/drivers/mops_client.py

@@ -7,7 +7,7 @@
   - HTTP Basic auth (same credentials as SSH/SNMP)
   - No net-snmp/pysnmp dependency — just requests + xml.etree
 
-Adapted from Hirschy-MOPS/lib/mops.py for use as a napalm-hios transport.
+Adapted from Hirschy-MOPS/lib/mops.py for use as a crude-engine transport.
 
 Usage:
     from crude_engine.drivers.mops_client import MOPSClient

crude_engine/drivers/mops_driver.py

@@ -1,5 +1,5 @@
 """
-MOPS.py — MOPS protocol driver for napalm-hios.
+MOPS.py — MOPS protocol driver for crude-engine.
 
 Layer: Driver. Translates wire YAML source dicts into MOPS operations.
 Owns: get_multi batching, index keying, row filtering, tag dispatch.

crude_engine/drivers/mops_transport.py

@@ -1,5 +1,5 @@
 """
-mops_transport.py — MOPS transport for napalm-hios.
+mops_transport.py — MOPS transport for crude-engine.
 
 Layer: Transport. Owns HTTPS session and raw MIB operations via XML.
 Cannot: interpret data meaning, decide what to gather, know about features.

crude_engine/drivers/offline_client.py

@@ -326,13 +326,10 @@ def get(self, mib_name, node_name, attributes, decode_strings=True):
     def get_multi(self, queries, decode_strings=True):
         """Multi-node lookup from in-memory data.
 
-        Returns: full parsed response dict (same as MOPSClient.get_multi)
+        Returns: dict keyed by MIB name, then node name: {mib: {node: [rows]}}
+        — same shape as MOPSClient.get_multi (parsed["mibs"]).
         """
-        result = {
-            "message_id": "0",
-            "mibs": {},
-            "errors": [],
-        }
+        mibs = {}
 
         for mib_name, node_name, attrs in queries:
             mib_data = self._data.get(mib_name)
@@ -354,11 +351,11 @@ def get_multi(self, queries, decode_strings=True):
                         filtered[attr] = value
                 filtered_entries.append(filtered)
 
-            if mib_name not in result["mibs"]:
-                result["mibs"][mib_name] = {}
-            result["mibs"][mib_name][node_name] = filtered_entries
+            if mib_name not in mibs:
+                mibs[mib_name] = {}
+            mibs[mib_name][node_name] = filtered_entries
 
-        return result
+        return mibs
 
     # ------------------------------------------------------------------
     # MOPSClient interface — write

crude_engine/drivers/offline_hios.py

@@ -1,5 +1,5 @@
 """
-offline_hios.py — Offline transport for napalm-hios.
+offline_hios.py — Offline transport for crude-engine.
 
 Layer: Transport. Loads config XML files via MOPS interface.
 Inherits MOPSHIOS — offline uses the same driver/engine path as MOPS.

crude_engine/drivers/snmp_driver.py

@@ -1,5 +1,5 @@
 """
-SNMP.py — SNMP protocol driver for napalm-hios.
+SNMP.py — SNMP protocol driver for crude-engine.
 
 Layer: Driver. Translates wire YAML source dicts into SNMP operations.
 Owns: walk batching, scalar normalization, index decomposition, tag dispatch.

crude_engine/drivers/snmp_transport.py

@@ -1,5 +1,5 @@
 """
-snmp_transport.py — SNMP transport for napalm-hios.
+snmp_transport.py — SNMP transport for crude-engine.
 
 Layer: Transport. Owns session, auth, and raw OID GET/SET/WALK.
 Cannot: interpret data meaning, decide what to gather, know about features.

crude_engine/drivers/ssh_driver.py

@@ -1,5 +1,5 @@
 """
-SSH_gather.py — SSH protocol driver for napalm-hios.
+SSH_gather.py — SSH protocol driver for crude-engine.
 
 Layer: Driver. Translates wire YAML source dicts into SSH CLI operations.
 Owns: command dedup, level navigation, CLI parsing, response caching.
@@ -84,6 +84,18 @@ def gather(self, sources: List[Tuple[str, Dict]],
                 logger.debug("SSH command failed: %s — %s", cmd, str(e)[:80])
                 ssh_cache[(cmd, level)] = ""
 
+        # Keep the command text for inspect/sidecar trace. Does not change
+        # parse or what was sent. Cap each blob so a poll body stays usable.
+        _cli = []
+        for (cmd, level), resp in ssh_cache.items():
+            text = resp if isinstance(resp, str) else str(resp)
+            if len(text) > 32768:
+                text = text[:32768] + "\n…truncated"
+            _cli.append({"command": cmd, "level": level, "response": text})
+        self.last_cli = _cli
+        if getattr(self, "transport", None) is not None:
+            self.transport.last_cli = _cli
+
         # Phase 3: Each attribute parses from cached response
         for name, source in sources:
             if source.get("iterate_from"):
@@ -97,7 +109,7 @@ def gather(self, sources: List[Tuple[str, Dict]],
             if val is None:
                 continue
             tag = self._resolve_tag(source.get("tag", ""), source, attr_name=name)
-            if isinstance(val, dict) and tag in AGGREGATE_TAGS:
+            if isinstance(val, dict) and self._tag_name(tag) in AGGREGATE_TAGS:
                 # Aggregate tag: pass whole dict to transform
                 results[name] = self._apply_pipeline(val, source, tag, value_maps)
             elif isinstance(val, dict):
@@ -177,7 +189,7 @@ def gather(self, sources: List[Tuple[str, Dict]],
                 resp = iterate_cache[cache_key]
                 val = self._parse_response(resp, source)
                 if val is not None:
-                    if isinstance(val, dict) and tag in AGGREGATE_TAGS:
+                    if isinstance(val, dict) and self._tag_name(tag) in AGGREGATE_TAGS:
                         val = self._apply_pipeline(val, source, tag, value_maps)
                     elif isinstance(val, dict):
                         val = {k: self._apply_pipeline(v, source, tag, value_maps)