schema+wire+fixtures: get_ip_addresses flat defaults + SSH prefix (#329) - #389
Draft
AdamRickards wants to merge 1 commit into
Draft
AdamRickards wants to merge 1 commit into
AdamRickards wants to merge 1 commit into
Conversation
defaults: {ipv4: {}} replaced by the flat scalar shape
{ipv4_address: '', ipv4_prefix: 0, ipv4_gateway: ''}, matching the
schema's own "Management IP" note that this method is a scalar dict,
not a per-interface table.
SSH: hm2netprefixlength wired to "show network parms" Subnetmask via a
new net_mask_to_prefix value_map (33 entries, prefix 0-32) in base
wire/netconfig.yaml. It sits in the base file because the load_wire()
overlay merge reads only attributes: (see companion park row).
Fixtures: sanitized hm2NetStaticGroup scalar block (RFC 5737
TEST-NET-1 placeholder) added to config_nvm_sample.xml; gold_floors.json
get_ip_addresses regenerated from {"ipv4": {}} to the 3 leaves the
fixture now produces. The old floor came from 259aee0 (#192) as an
empty Offline leaf. floors_provenance ssh untested -> pass and
FLOORS_BOARD.md regenerated; catalogue_inventory_draft.md note updated.
Schema, wire YAML and test fixtures only; no Engine files.
Live sidecar proof: untested (pending). Draft; do not merge.
Related #329
Owner
Author
|
Sidecar live proof + claims review for head Verdict: partial. All 3 protocols now gather live and agree. The gold regeneration misses Draft; do not merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for sidecar live proof; do not merge.
Replaces
get_ip_addressesdefaults: {ipv4: {}}with the flat scalar shape (ipv4_address,ipv4_prefix,ipv4_gateway) and wires SSHipv4_prefixfromshow network parmsSubnetmask via a newnet_mask_to_prefixvalue_map in basewire/netconfig.yaml(#329). Fixtures: sanitizedhm2NetStaticGroupblock (RFC 5737 placeholder) inconfig_nvm_sample.xml,gold_floors.jsonget_ip_addressesregenerated to 3 leaves,floors_provenancessh untested -> pass,FLOORS_BOARD.mdregenerated.Offline (tested):
{ipv4: {}}even against a fixture that carrieshm2NetStaticGroup; on this head both return the 3 leaves (prefix 24 via the value_map).offline_gold_matrix.py --methods get_ip_addresses: 3 real leaf matches (main: 1 vacuous "both empty").get_management.prefix_length offline=24 gold=0. The new fixture block also feedsget_management, whose gold was not regenerated.Live (untested, pending): sidecar
get_ip_addresses.readmops/snmp/ssh on this head vs main. Thessh: passprovenance flip is pending that proof.Schema, wire YAML and fixtures only; no Engine files.
Related #329