Repository navigation
wire: SSH read side for get_lldp_neighbors(_detail) via parser: sections (#333, #334) - #390
Draft
AdamRickards wants to merge 1 commit into
Draft
AdamRickards wants to merge 1 commit into
AdamRickards wants to merge 1 commit into
Conversation
…ons (#333, #334) Wires "show lldp remote-data" to the existing SSH sections parser (_parse_sections in ssh_driver.py), which no wire YAML referenced before. Default section header/key extraction is used unchanged. 11 of 14 get_lldp_neighbors_detail attributes get an SSH source: local_port (section key), port_id, chassis_id, sys_name, sys_description, port_description (wire/ssh/lldp.yaml), pvid (new wire/ssh/lldp-ext-dot1.yaml), mau_type, aggregation_port_id, autoneg_supported, autoneg_enabled (new wire/ssh/lldp-ext-dot3.yaml). Overlays are split per base wire file because load_wire() merges an overlay by the attribute's source: feature. port_id/chassis_id use regex + case: lower; mau_type strips the annotation with regex; autoneg supported/enabled are two regexes on one CLI field. Declarative YAML only (existing regex:/case: hints). Deliberately not wired, noted in wire and schema comments: sys_capabilities, sys_enabled_capabilities (no field in this command's output) and aggregation_enabled (only one text phrase observed; the value_map would be guessed). Wire + schema YAML (comment) only; no Engine files. Live sidecar proof: untested (pending). Draft; do not merge. Related #333 #334
This was referenced Sep 29, 2026
Owner
Author
|
Sidecar live proof + claims review for head Verdict: partial. SSH goes from 0 to 7 rows on both methods; 9 of 11 wired attributes match SNMP 7/7, and Draft; do not merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for sidecar live proof; do not merge.
Wires the SSH read side of
get_lldp_neighbors/get_lldp_neighbors_detail(#333, #334) toshow lldp remote-datathrough the existingparser: sections(_parse_sectionsinssh_driver.py, dispatched since the first commit, not referenced by any wire YAML on main).11 of 14 detail attributes get an SSH source:
local_port(section key),port_id,chassis_id,sys_name,sys_description,port_description(wire/ssh/lldp.yaml);pvid(newwire/ssh/lldp-ext-dot1.yaml);mau_type,aggregation_port_id,autoneg_supported,autoneg_enabled(newwire/ssh/lldp-ext-dot3.yaml). Overlays are split per base wire file becauseload_wire()merges an overlay persource:feature.Deliberately not wired (noted in wire + schema comments):
sys_capabilities,sys_enabled_capabilities,aggregation_enabled.Offline (tested): pytest, ci_offline, floors board check pass; offline_gold_matrix shows no new mismatch (2 known on main).
Live (untested, pending): sidecar
get_lldp_neighbors.readandget_lldp_neighbors_detail.readmops/snmp/ssh on this head vs main: row counts and per-attribute SSH vs SNMP values.Wire + schema YAML (comment) only; no Engine files.
Related #333 #334