docs(agents): park load_wire() overlay merge dropping value_maps (#329) - #391
Draft
AdamRickards wants to merge 1 commit into
Draft
AdamRickards wants to merge 1 commit into
AdamRickards wants to merge 1 commit into
Conversation
Adds a hitl-engine-park.md row: load_wire()'s protocol-overlay merge
(interpreter.py) merges only the overlay's attributes: block, so a
top-level value_maps: in wire/{overlay_dir}/{wire_id}.yaml is never
read; only the base file's value_maps: is used.
Found while wiring #329's SSH-only net_mask_to_prefix map, which had to
move into base wire/netconfig.yaml. Fix shape (mirror the attributes
merge for value_maps) is Engine-touching and needs HITL sign-off; not
implemented here.
Docs only. Offline repro: tested. Draft; do not merge.
Related #329
Owner
Author
|
Offline repro + claims review for head Verdict: pass. Draft; do not merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for sidecar live proof; do not merge.
Docs only: adds a
hitl-engine-park.mdrow.load_wire()'s protocol-overlay merge (interpreter.py) merges only the overlay'sattributes:, so a top-levelvalue_maps:inwire/{overlay_dir}/{wire_id}.yamlis never read. Found while wiring #329's SSH-onlynet_mask_to_prefixmap (#329 keeps it in basewire/netconfig.yamlas a workaround).Offline (tested): a minimal probe on a throwaway copy of main adds a
value_maps:entry towire/ssh/netconfig.yaml.load_wire("netconfig", "ssh")keeps the overlay's attribute source but not the map (merged keys = base keys only). With #329's map moved into the SSH overlay, SSHipv4_prefixreturns the raw mask string instead of 24.Live: not applicable (docs only).
Fix shape (Engine, needs HITL sign-off): mirror the
attributes:merge forvalue_maps:. Not implemented here.Related #329