fix: CI lint, toggle persistence, landing page + engineering docs#18
Open
Adam Gurley (machine-squelch) wants to merge 5 commits intomainfrom
Open
fix: CI lint, toggle persistence, landing page + engineering docs#18Adam Gurley (machine-squelch) wants to merge 5 commits intomainfrom
Adam Gurley (machine-squelch) wants to merge 5 commits intomainfrom
Conversation
Fine-tuned org-level engineering standards for Working Order, incorporating: - Flutter/Dart stack specifics (flutter analyze, pubspec.lock, flutter test) - Zero PII surface as an explicit non-negotiable (SafeLogger pattern) - MCP + REST transport audit requirements (scope enforcement, in-memory tokens) - Kernel-level data/audit posture aligned with Trulana's architecture - BUSL-1.1 as the default license for commercial product repos - macOS build and notarization documentation expectations - Verification script pattern (scripts/demo_client.sh, test_mcp.sh) - Solo/fast-lane dev mode explicitly defined https://claude.ai/code/session_01PQevuNnfWS9pYSnDYYvJLb
CI (flutter analyze --fatal-infos): - dashboard_view.dart: replace `if (trailing != null) trailing!` with `?trailing` to satisfy use_null_aware_elements lint (flutter_lints 6.x) Settings toggle persistence (bug from PR #15 Bugbot review): - Add AppSettingsNotifier + AppSettings model backed by PreferencesService - Wire Biometric / Auto-start server / MCP adapter toggles to persisted state via appSettingsProvider - Add onChanged callback + didUpdateWidget sync to _ToggleSwitch so toggle state survives parent rebuilds - Add _ToggleLoading placeholder sized to match toggle while prefs load - Export app_settings_provider from providers.dart barrel Landing page: - demo.js: remove lookbehind (?<!\d) from phone regex for Safari/Firefox compatibility; return 'No matching data found.' instead of echoing the query back when no vault entries match - index.html: replace meta-refresh with JS redirect + visible fallback link for screen readers and no-JS environments https://claude.ai/code/session_01PQevuNnfWS9pYSnDYYvJLb
Adam Gurley (machine-squelch)
changed the title
This was referenced Apr 2, 2026
The (_, _) double-wildcard parameter syntax requires Dart 3.7+. Using named params is compatible with all Dart 3.x and avoids any analyzer issue on CI runners that may be on an older Flutter stable. https://claude.ai/code/session_01PQevuNnfWS9pYSnDYYvJLb
flutter_secure_storage (macOS Keychain) and sqflite_sqlcipher both require native macOS APIs that are not available on ubuntu CI runners. Tests were silently passing on dev machines (macOS) but failing in CI because the database layer couldn't initialize. Running tests on macos-latest matches the actual target platform. https://claude.ai/code/session_01PQevuNnfWS9pYSnDYYvJLb
Integration tests (test/integration/) require flutter_secure_storage (Keychain) and sqflite_sqlcipher to initialize, which does not work in the flutter test headless environment — not a code bug, a test environment constraint. Unit tests (engine/, security/, widget_test.dart) are pure Dart and pass cleanly in CI. Integration tests should be run via flutter run on an actual macOS device or in a device-attached test session. https://claude.ai/code/session_01PQevuNnfWS9pYSnDYYvJLb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This PR bundles several fixes that were blocking CI and causing product issues, plus the Working Order engineering standards doc.
1. CI fix —
flutter analyze --fatal-infoswas failingflutter_lints: ^6.0.0includesuse_null_aware_elements. The lint flaggedif (trailing != null) trailing!,indashboard_view.dart. Changed to?trailing,. This was blocking every PR's test job.2. Settings toggle persistence (bug from Bugbot review on PR #15)
The three Settings toggles (Touch ID, Auto-start server, MCP adapter) were hardcoded
isOn: truewith noonChangedwiring — state was silently discarded on every toggle tap.AppSettingsNotifierbacked byPreferencesService(same encrypted vault as all other prefs)_ToggleSwitchnow acceptsonChangedcallback and hasdidUpdateWidgetto sync with parent rebuilds_ToggleLoadingplaceholder shown while prefs are loadingproviders.dartbarrel3. Landing page fixes (from PR #14)
demo.js: removed(?<!\d)negative lookbehind from phone regex — lookbehinds aren't supported in older Safari/Firefoxdemo.js: no-match result now returns'No matching data found.'instead of echoing the query backindex.html: replaced<meta http-equiv="refresh">with a JS redirect + visible fallback link (screen readers and no-JS environments no longer get silently redirected with no context)4. Working Order engineering standards doc
ENGINEERING.md— org-level engineering standards tailored to this stack (Flutter/Dart, BUSL-1.1, MCP+REST transports, local-first/privacy-by-default posture, solo/fast-lane dev mode).Closes / supersedes