Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the second pull request in the multi-tenant platform chain and targets
feat/multitenant-p2-postgresqlso the review contains only P3.__Host-cookies, rotation, logout and expiry handlingSecurity correction
Strict review found that the initial RLS policy trusted only the workspace GUC. The final correction binds access to both the workspace and an active membership for
current_user_id, fails closed for missing/mismatched context, uses a lockedNOLOGINhelper role, and includes real PostgreSQL RED→GREEN isolation coverage.Verification
d94c10c7755f84d75fab5fa4855c13b138e62d22077c08a0a331812fda73a17433341e7375a06cea1baeef6b7f318e639401696e9efcf702091890f241eab2f79700b76b50dfb5ccCI,Security,P1 quality, andP2 PostgreSQL migrations: PASS on the final headScope boundary
P4 OAuth/PKCE, token vault, provider connections, UI and background jobs are intentionally out of scope.