Phase 5 frontend - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the frontend auth and routing layer by adding a server-backed logout call and expanding access to the approvals queue for additional roles.
Changes:
- Added
POST /auth/logoutAPI wrapper and wiredAuthContext.logout()to call it before client-side cleanup. - Expanded
ProtectedRouterole access for the approvals queue routes to includefinanceanddirector. - Cleaned up/standardized router route declarations for
/dashboardand/expenses.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/context/AuthContext.jsx | Updates logout flow to attempt a backend logout request before clearing local auth state and redirecting. |
| frontend/src/app/router.jsx | Expands allowed roles for approvals-related routes and tidies route declarations. |
| frontend/src/api/authService.js | Adds a logout() API function and normalizes formatting of existing auth API calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
48
to
52
| path="/manager" | ||
| element={ | ||
| <ProtectedRoute allowedRoles={["manager", "admin"]}> | ||
| <ProtectedRoute allowedRoles={["manager", "finance", "director", "admin"]}> | ||
| <ApprovalQueuePage /> | ||
| </ProtectedRoute> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.