Fixes for Windows Linux subsystem shell and Cygwin bash#21
Open
lheinman wants to merge 11 commits into
Open
Conversation
lheinman
commented
Jul 22, 2019
lheinman
commented
- Created a Powershell script to convert file path provided by IntelliJ to *nix format.
- Updated README.md to reflect changes in IntelliJ keyboard shortcuts configuration.
- Provided a workaround for a Cygwin's curl problem: unable to open files in absolute paths, such as /tmp
Fixes for Windows Linux subsystem shell and Cygwin bash
Updated README.md, moved code around
alexkli
requested changes
Jul 22, 2019
alexkli
added
bug
enhancement
waiting for response
Clirified use of Cygwin in the wrapper script; wrapper code cleanup
Renamed repoWrapper to repoWin; reverted some of repoWin code cleanup
Moved backslash flipping code into 'repo' bash shell script to enable using 'repo' from Cygwin bash directly
alexkli
reviewed
Aug 10, 2019
| $path = $path -replace '.:',"/mnt/c" | ||
|
|
||
| $cmdPath = $cmdPath -replace '\\','/' | ||
| $cmdPath = $cmdPath -replace '.:','/mnt/c' |
Contributor
There was a problem hiding this comment.
Is there a reason why this logic can't be in repo too?
Author
There was a problem hiding this comment.
Putting this code in repo results in stripping all backslashes. For path:
repo: does not exist: C:DevgitDigitalPlatformuisrcmaincontentjcr_rootappschipotlecomponentsstructurepagev1pagepartialsgascript.html
for cmdPath:
/bin/bash: C:githubtoolsrepo/repo: No such file or directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.