CEXT-6229: Extend OutOfProcessTotalsCollector to support custom fee total types#562
Conversation
| @@ -1,14 +1,14 @@ | |||
| --- | |||
| title: Totals collector development considerations | |||
There was a problem hiding this comment.
Why are we adding it here? Should it not go here? https://developer.adobe.com/commerce/extensibility/webhooks/use-cases/
There was a problem hiding this comment.
We already have this documentation for the Oope total collector module. So for me, it makes sense to new webhooks from that module to the same documentation.
| The out-of-process totals collector exposes a dedicated webhook for custom fees: | ||
|
|
||
| ``` | ||
| plugin.magento.out_of_process_totals_collector.api.get_total_modifications.custom_fees |
There was a problem hiding this comment.
As a plugin, does it require di:compile in PaaS? If it's the case, please add the disclaimer
There was a problem hiding this comment.
It's already available in ACCS. It requires webhook module generation after webhook subscription and di:compile after that as well.
|
|
||
| To apply fees from an external service, register a webhook for the method `plugin.magento.out_of_process_totals_collector.api.get_total_modifications.custom_fees` (type `after`). | ||
|
|
||
| [PaaS Only](https://experienceleague.adobe.com/en/docs/commerce/user-guides/product-solutions) To register the webhook, [modify the `webhooks.xml` file](../../webhooks/hooks.md) (in your module or in `app/etc`): |
There was a problem hiding this comment.
I think we should have a central point that explains how to register webhooks, we have that information duplicated in many places. in other hand, should not be REST API & App Management the preferred registration mechanism for a webhook?
There was a problem hiding this comment.
Yes, the REST API & App Management should be preferred. But in Paas, we still have an unresolved issue: plugin-type webhooks must be in XML files to generate the required plugins during the build phase.
There was a problem hiding this comment.
I think we should have a central point that explains how to register webhooks, we have that information duplicated in many places
I believe the central point is in the webhooks documentation itself.
github-project-automation
Bot
moved this from 📋 Needs Review
to 👍 Approved
in Commerce - Pull Requests
Updated the documentation for the out-of-process totals collector webhook to clarify its functionality and usage.
keharper
added
internal
🔍 Linter ReportClick to expand full reportThis comment was automatically generated by the linter bot. |
github-project-automation
Bot
moved this from 👍 Approved
to 🏁 Done
in Commerce - Pull Requests
4 participants
Purpose of this pull request
This pull request (PR) adds information and examples on how to add custom fees using a new webhook.
https://jira.corp.adobe.com/browse/CEXT-6229
Affected pages
Links to Magento Open Source code