Repository navigation
fix(scoring): grade the score that is shown (extension 0.3.2) - #122
Merged
Merged
Conversation
The engine rounded the overall score for display but graded the unrounded value, so a raw 59.7 showed as 60 with grade F, and 79.6 showed as 80 with grade C. Seen live in the extension on amazon.com and adidas.com (60, F) and microsoft.com, uber.com and ford.com (80, C). Round once and grade the rounded number. The E-E-A-T scorer already did this. Adds a regression test (59.7 -> 60, D). Bumps the extension to 0.3.2.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
aggregateScorereturnedoverall: Math.round(overall)butgrade: scoreToGrade(overall)on the unrounded value. Users saw a score and grade that disagree:Fix
Round once in
packages/scoring/src/engine.tsand grade the rounded number. The E-E-A-T scorer (eeat-rules.ts) already rounded before grading, so it is unchanged.overall: 60, grade: 'D'(failed before the fix withexpected 'F' to be 'D').@advance-labs/scoringpatch.Verified
pnpm turbo run test: 12 tasks, 280 tests across 8 packages, all pass. Typecheck clean.After merge
@advance-labs/scoring.🤖 Generated with Claude Code