Repository navigation
feat(scoring,crawler): skip noindex pages in per-page scoring, honour nofollow - #126
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages that opt out of indexing were scored like any other. On aeo.advancelabs.dev,
/login(noindex, nofollow, not in the sitemap) was reached through the "Sign in" link and produced 4 failures including a false critical.Behaviour
noindex(meta robots, orX-Robots-Tag, includingnone; header agent prefixes count only for googlebot/bingbot) are removed fromctx.pagesand, whenstructuredDatalines up one-to-one withpages, fromctx.structuredData.ctx.crawlis untouched. They stay inpagesCrawledand appear in the newAuditReport.excludedPagesas{url, reason: 'noindex'}, so nothing disappears silently. If every page is noindex, nothing is excluded.nofollow/none(meta or header) is fetched and recorded but its links are not followed;<a rel=nofollow>links are skipped.noindexalone still follows links.Rule.includesNoindexPages.Per-rule decisions
tech.indexable: full context, with a narrower definition of defect. A noindex page is flagged if it is the root, if the sitemap lists it (contradiction), or if there is no sitemap to show intent. A noindex page that a non-empty sitemap leaves out is treated as a deliberate opt-out (login, checkout). Without this, /login would still raise the critical.tech.canonical-present,tech.canonical-resolves: full context (canonical checks are inspection rules; unchanged behaviour).tech.sitemap-covers-pages: already skipped noindex pages; unchanged.crawl.pages): readctx.crawl, which is not filtered; unchanged.Tests: scoring
noindex.test.ts(12) and crawler links/crawl tests. Changesets: scoring minor, types minor, crawler patch.