Repository navigation
v1.4.0: a Custom Elements Manifest - #5
Merged
Merged
Conversation
webcomponents.org does not take pull requests. Its catalog server indexes npm packages and reads their Custom Elements Manifest, so the listing is not a submission, it is a file in the package. Adding it is what makes us indexable. It earns its place either way. The same manifest is what VS Code and the JetBrains IDEs read for tag and attribute autocomplete, so anyone who installs the package gets completion on data-position, data-llms and the rest without looking anything up. The manifest documents the two CSS custom properties as well as the attributes, including the part a host gets wrong: --hms-top and --hms-bottom have to be set together, because a fixed box with both edges set and height auto stretches. Two tests pin it to the component. Every attribute the manifest advertises must actually be read by the source, and every custom property it documents must appear there. A manifest that drifts is worse than none: it describes attributes that do nothing, in the one place a tool trusts without checking. 34 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webcomponents.org does not take pull requests. Its catalog server indexes npm packages and reads their Custom Elements Manifest, so the "listing" is not a submission — it is a file in the package.
It earns its place regardless
The same manifest is what VS Code and the JetBrains IDEs read for tag and attribute autocomplete. Anyone who installs the package gets completion on
data-position,data-llmsand the rest without looking anything up.It also documents the two CSS custom properties, including the part hosts get wrong:
--hms-topand--hms-bottomhave to be set together, because a fixed box with both edges set andheight: autostretches.Two tests pin it to the component
A manifest that drifts is worse than none: it describes attributes that do nothing, in the one place a tool trusts without checking.
34 tests, up from 32.
🤖 Generated with Claude Code