Repository navigation
feat(agent-status): say that a completed status is unseen - #181
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
zordhalo
force-pushed
the
feat/status-grammar
branch
from
November 12, 2026 20:48
de0b564 to
486ab5f
Compare
zordhalo
marked this pull request as ready for review
November 12, 2026 20:48
completed already clears once the user views the conversation (seen state is persisted per conversation). Name that in the tooltip and story, and add a test for the seen/clear and task-level ranking behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lukce <krawczakluke@gmail.com>
zordhalo
force-pushed
the
feat/status-grammar
branch
from
November 12, 2026 20:56
486ab5f to
f3af29f
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lukce <krawczakluke@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Plan item P1 (U1), "one status grammar with done, unseen". Investigation showed almost all of it already exists, so this PR is deliberately small.
Already true on
main:completedis "done, unseen":ConversationStore.indicatorStatusreturns it only whileagentStatusSeenis false. The flag is persisted in the existingconversationsrow (written byAgentStatusService, cleared bymarkConversationSeenwhen the tab or panel is viewed). No new store or migration is needed.AgentStatusfrom@emdash/ui, is used by sidebar task rows, sidebar conversation lists, conversation and ACP chat tabs, the command palette task and conversation rows, and the project task list. Task-level status isConversationManagerStore.taskStatus(awaiting-input > working > error > completed).workingandawaiting-inputanimations already honourprefers-reduced-motion;completedanderrorare static.Stopis derived (subagents); the vocabulary is unchanged.Changed:
completedtooltip/aria label now reads "Agent finished, not yet viewed", and the story label says "Completed (done, unseen)". The StorybookAllStatesstory already shows every state.Follow-up, not in this PR (lanes is a CODEOWNERS security path):
features/lanes/browser/status-light.tsxhas its ownLaneStatus(idle, running, waiting, verifying, blocked, asleep) rendered as dots withanimate-pulse(no reduced-motion guard). A follow-up should map running to working, waiting and blocked to awaiting-input, idle and asleep to idle, and verifying to working, then renderAgentStatus.How it was tested
vitest --project browser conversation-seen-status.browser.test.ts: 2 passed (thenodeproject cannot import the conversation manager, so it is a browser-project file).pnpm --dir apps/emdash-desktop run typecheck: clean.oxfmt/oxlinton changed files;node tooling/scripts/check-upstream-patches.mjs --base origin/main: clean.pnpm run checkfull gate (pre-push hook skipped for machine load, CI runs it).Checklist
🤖 Generated with Claude Code