Repository navigation
Conversation
The sidebar tree takes arrow, j/k, Home/End, Enter and Space keys with tree semantics and aria-activedescendant. F6 and Shift+F6 cycle focus through the sidebar, main area, terminal drawer and right sidebar, skipping closed regions. Mod+Shift+0 focuses the sidebar (Mod+0 is Electron's zoom reset). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lukce <krawczakluke@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Plan task P3 (idea U2): the whole window can be driven without a mouse.
role="tree"withtreeitemrows (aria-level,aria-expanded,aria-selected,aria-posinset,aria-setsize) andaria-activedescendant, so focus never chases rows the virtualizer unmounts. Down/Up andj/kmove, Left/Right collapse, expand or go to the parent or first child, Home/End jump, Enter opens, Space opens a task or toggles a project. The focused row scrolls into view and shows a focus ring. Keys act only when the tree itself has focus, so typing in an input or pressing a row's own buttons is untouched.data-focus-region; the existingfocusedRegion(main | bottom) is untouched and stays in sync through the existingonFocushandlers, so there is no parallel state.Default keybindings, all rebindable in Settings → Keyboard shortcuts and in the command palette:
Mod+0 is not used: the View menu has Electron's
resetZoomrole on CmdOrCtrl+0, so it would clash. Mod+Shift+0 sits beside the task view's Mod+Shift+1 to 3. All three work while a terminal has focus.Does not touch
features/lanes/. No new dependencies. Logged as UPSTREAM-PATCHES 97.How it was tested
pnpm exec oxfmtandpnpm exec oxlintfromapps/emdash-desktop(101 files, 0 warnings, 0 errors)nx run @emdash/emdash-desktop:typecheck: passesvitest --project node:sidebar-tree-keys.test.ts,focus-regions.test.ts, plussrc/core/manifests/shared,primitives/keybindings,features/workbench,features/settings,primitives/palette(273 tests pass)vitest --project browser sidebar-keyboard.browser.test.tsx: tree semantics, arrows and j/k, Home/End, expand and collapse, Enter and Space open, input is not stolen from, region cycling with a hidden region skippednode tooling/scripts/check-upstream-patches.mjs --base origin/main: passesScreenshots (UI changes)
None; the only visible change is a focus ring on the keyboard-focused sidebar row.
Checklist
pnpm run checkpasses locally (focused checks only, see above)git commit -s) and the PR title is a Conventional Commitdocs/UPSTREAM-PATCHES.mddocs/guide/updated🤖 Generated with Claude Code