Add type definitions#23
Open
JonathanXDR wants to merge 1 commit into
Open
Conversation
Fixes Advanon#22 Add TypeScript type definitions to the `pdf-signatures` package. * **Add `src/main/js/index.d.ts` file:** - Define TypeScript types for `addSignaturePlaceholderToPdf`, `pdfDigest`, `signPdf`, and `addLtvToPdf` functions. - Define TypeScript types for `CertificationLevels` and `HashAlgorithms` enums. - Add JSDoc comments to the type definitions for better documentation. - Add detailed comments for each function and interface to provide better context and usage examples. - Add interfaces for the return types of the functions for better type safety. - Create separate interfaces for different types of errors that can be thrown by the functions, such as `PdfSignaturesError`. * **Update `package.json`:** - Add `types` field pointing to `src/main/js/index.d.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Advanon/pdf-signatures/issues/22?shareId=XXXX-XXXX-XXXX-XXXX).
JonathanXDR
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Add TypeScript type definitions to the
pdf-signaturespackage.Add
src/main/js/index.d.tsfile:addSignaturePlaceholderToPdf,pdfDigest,signPdf, andaddLtvToPdffunctions.CertificationLevelsandHashAlgorithmsenums.PdfSignaturesError.Update
package.json:typesfield pointing tosrc/main/js/index.d.ts.For more details, open the Copilot Workspace session.