Localization: fix simulator localizations not being picked up in debug mode#2467
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue where localization strings were not being correctly loaded and applied within the simulator environment during debug sessions. The fix involved a strategic migration of localization resources from the modern .xcstrings format back to the more traditional .strings format, coupled with necessary updates to the Xcode project configuration to ensure these files are properly recognized and bundled. This change ensures that localized content is correctly displayed in the simulator, improving the debugging experience for internationalized applications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the localization files from the .xcstrings format to the traditional .strings format. This includes deleting the old Localizable.xcstrings file, creating new Localizable.strings files for English and Hindi with the extracted string content, and updating the Xcode project file (Adyen.xcodeproj/project.pbxproj) to reference these new .strings files and their variant group. There are no review comments to address.
|
ℹ️ No baseline data found for 'feature/cosdk-1097-ios-v6-custom-localization-develop'.
|
…into chore/fix-simulator-localizations
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay |
53bb547
into
feature/cosdk-1097-ios-v6-custom-localization-develop
Summary
This PR:
Demo
Technical Information
Main localization logic changes in this PR:
Bundle.main-> optionalLocalizationParameters.bundle-> SDK localized resources -> SDKen-US-> raw key.lprojfrom each candidate bundle before falling back to SDK resourcesShow non-localized stringsuppercase placeholder output as a missing translation so fallback continues correctlyTesting Instructions
AdyenUIHostLocalizationTestsand confirm the debug placeholder case passesTicket
COSDK-1097Checklist