[v6] (1/2) BACS Direct Debit: Remove confirmation screen by nauaros · Pull Request #2597 · Adyen/adyen-ios

nauaros · 2026-06-16T11:10:39Z

Summary

This PR removes the confirmation screen from the BACSDirectDebitComponent, turning it into a single-screen component. This aligns BACS with the rest of our payment components (like SEPA and ACH), simplifies the user experience, and reduces checkout friction.

Key Changes

Single-Screen Flow: Users now submit payments directly from the input form.
submit() Method Support: Form validation and submission can now be triggered programmatically via the submit() function.
Custom Button Support: Enables seamless integration with custom submit buttons.

Demo

Before	After
BACS_v5.mov	BACS_v6.mov

Ticket

COSDK-1284

Checklist [Required]

Tested changes locally
Added/updated unit tests (Follow up PR)
Verified against acceptance criteria
Aligned public API changes with other platforms (if applicable)

…S_remove_review_screen # Conflicts: # AdyenComponents/BACS Direct Debit/BACSDirectDebitComponent.swift

…o chore/BACS_remove_confirmation_screen

github-actions · 2026-06-16T11:12:27Z

ℹ️ No baseline data found for 'feature/COSDK-1284_Remove_confirmation_screen_BACS'.

Framework	Size
AdyenComponents.framework	2472 KB
AdyenActions.framework	2364 KB
AdyenDropIn.framework	1373 KB
AdyenDelegatedAuthentication.framework	158 KB
AdyenAuthentication.framework	347 KB
AdyenWeChatPay.framework	274 KB
AdyenUI.framework	3272 KB
AdyenCardScanner.framework	689 KB
AdyenEncryption.framework	506 KB
AdyenSession.framework	674 KB
AdyenTwint.framework	263 KB
AdyenWeChatPayInternal.framework	4135 KB
AdyenCheckout.framework	2377 KB
AdyenCashAppPay.framework	1764 KB
AdyenCard.framework	1685 KB
TwintSDK.framework	97 KB
Adyen3DS2.framework	919 KB
Adyen.framework	5169 KB
total	28538 KB

gemini-code-assist

Code Review

This pull request refactors the BACS Direct Debit component to use an MVVM architecture, introducing BACSViewController and BACSViewModel while removing the previous presenter-router pattern and the confirmation screen. It also updates the form UI components to support existential any FormItem types. The review feedback highlights several critical compilation errors in the tests, a missing shopperEmail property and parameter in BACSDirectDebitDetails, a potential silent failure in performSubmit(), unnecessary use of @Published in the view model, and opportunities to reduce code duplication in the form view manager and controller.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

nauaros · 2026-06-16T12:31:37Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the BACS Direct Debit component by removing the confirmation screen and transitioning to a view model-based architecture using BACSViewModel and BACSViewController. However, several critical compilation errors were introduced in the integration tests due to references to undefined protocols, private properties, and removed properties. Additionally, the shopper's email address is collected but not propagated to the backend, and the items array in BACSViewModel should be simplified to a non-optional array using compactMap to avoid unnecessary optional-handling helpers in FormViewController.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

github-actions · 2026-06-16T14:18:54Z

⚠️ 2 public changes detected ⚠️

Comparing chore/BACS_remove_confirmation_screen to feature/COSDK-1284_Remove_confirmation_screen_BACS
Platform: iOS

❇️	1 Addition
🔀	1 Modification

`AdyenComponents`

`BACSDirectDebitDetails`

❇️ Added

public let shopperEmail: Swift.String? { get }

🔀 Modified

// From
public init(
  paymentMethod: Adyen.BACSDirectDebitPaymentMethod,
  holderName: Swift.String,
  bankAccountNumber: Swift.String,
  bankLocationId: Swift.String
)

// To
public init(
  paymentMethod: Adyen.BACSDirectDebitPaymentMethod,
  holderName: Swift.String,
  bankAccountNumber: Swift.String,
  bankLocationId: Swift.String,
  shopperEmail: Swift.String? = nil
)

/**
Changes:
- Added parameter `shopperEmail: Swift.String? = nil`
*/

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay

atmamont · 2026-06-18T09:27:39Z

    // MARK: - PresentableComponent

-    package let viewController: UIViewController
+    package lazy var viewController: UIViewController = {


Doesn't this approach limit our testing capabilities? Passing a mock view controller could help us cover the lifecycle events if needed.

atmamont · 2026-06-18T09:30:07Z

+
+    // MARK: - Private
+
+    private func createViewController() -> UIViewController {


Can we think of extracting assembly code from the payment business logic to another assembly/provider/factory?

atmamont · 2026-06-18T10:58:53Z

+import Combine
+import UIKit
+
+internal final class BACSViewController: FormViewController {


I noticed #if canImport(AdyenUI) bracket in the imports section, but it's missing from here where we actually use the FormViewController itself.

atmamont · 2026-06-18T11:35:50Z

+import Adyen
+#if canImport(AdyenUI)
+    import AdyenUI
+    @_spi(AdyenInternal) import class AdyenUI.FormTextInputItem


This makes view model impossible to reuse when(if) we migrate to SwiftUI without code changes.

Or maybe there is a way to decouple FormTextInputItem from AdyenUI, as we treat item as a business logic layer model. Just a thought for future decisions.

atmamont · 2026-06-18T11:39:29Z

+            return
+        }
+
+        guard let holderName = holderNameItem?.value,


this code section does exactly what the prior one promised - validation.
If we have to rely of FormViewController validation, then we can extract local validation rules to a separate method that in turn will call validateForm()

atmamont · 2026-06-18T11:40:27Z

+        submitButtonItem?.showsActivityIndicator = true
+    }
+
+    private func createItems() -> [any FormItem] {


Extracting helper methods to a separate extension would make code easier to read (can be skipped honestly)

atmamont

Architecture choice seems to be a bit verbose for the task, with some concerns regarding future adoption of SwiftUI. Happy to discuss it later, these are non-blocking thoughts.

robertdalmeida · 2026-06-19T09:58:03Z

+
+    override internal func viewDidLoad() {
+        super.viewDidLoad()
+        viewModel.viewDidLoad()


thought;
i think if we need to inform the viewModel that controller finished/"did" load, it should be at the end of this method after doing everything? (to avoid any timing issues).

nauaros added 13 commits June 9, 2026 20:51

Revove BACSConfirmation

37758ef

Implement BACSViewModel

d63a699

Remove BACSViewModelProtocol

c090a46

Inject configuration into ViewModel

e2648a4

Address retain cycles

b75183f

Add shopper email to details

b03b02a

Remove shopperEmail from details

c47aa67

Remove presentationDelegate

3daa169

Remove presentationDelegate in ComponentManager

0c8358e

Merge branch 'feature/COSDK-1103_v6_instant_component' into chore/BAC…

001de8c

…S_remove_review_screen # Conflicts: # AdyenComponents/BACS Direct Debit/BACSDirectDebitComponent.swift

Merge branch 'develop' into chore/BACS_remove_review_screen

73e0e26

Merge branch 'feature/COSDK-1284_Remove_confirmation_screen_BACS' int…

098f05d

…o chore/BACS_remove_confirmation_screen

Rename submit to performSubmit

d682f55

nauaros self-assigned this Jun 16, 2026

nauaros added the chore a pull request that has chore changes that shouldn't be in the release notes label Jun 16, 2026

github-actions Bot added the size:medium label Jun 16, 2026

github-actions Bot approved these changes Jun 16, 2026

View reviewed changes

gemini-code-assist Bot reviewed Jun 16, 2026

View reviewed changes

nauaros closed this Jun 16, 2026

nauaros added 2 commits June 16, 2026 13:23

Remove duplicated methods

b4bc0c8

Remove published items property

2e69f78

Adyen deleted a comment from gemini-code-assist Bot Jun 16, 2026

nauaros reopened this Jun 16, 2026

Add items inline instead of function

0161acd

gemini-code-assist Bot reviewed Jun 16, 2026

View reviewed changes

nauaros added 2 commits June 16, 2026 14:55

Make items not optional

76d0723

Add shopperEmail in BACS details by making it ShopperInformation

735df2c

Adyen deleted a comment from gemini-code-assist Bot Jun 16, 2026

Discard changes in FormViewController

8f01ff7

nauaros requested review from atmamont and robertdalmeida June 16, 2026 17:43

nauaros marked this pull request as ready for review June 16, 2026 17:43

nauaros changed the title ~~[v6] BACS Direct Debit: Remove confirmation screen~~ [v6] (1/2) BACS Direct Debit: Remove confirmation screen Jun 17, 2026

atmamont reviewed Jun 18, 2026

View reviewed changes

atmamont approved these changes Jun 18, 2026

View reviewed changes

robertdalmeida reviewed Jun 19, 2026

View reviewed changes


		// MARK: - Private

		private func createViewController() -> UIViewController {

Conversation

nauaros commented Jun 16, 2026

Summary

Key Changes

Demo

Ticket

Checklist [Required]

Uh oh!

github-actions Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nauaros commented Jun 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 16, 2026

⚠️ 2 public changes detected ⚠️

AdyenComponents

BACSDirectDebitDetails

❇️ Added

🔀 Modified

Uh oh!

atmamont Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

atmamont Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

atmamont Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

atmamont Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

atmamont Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

atmamont Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

atmamont Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

atmamont left a comment

Choose a reason for hiding this comment

Uh oh!

robertdalmeida Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 16, 2026 •

edited

Loading

`AdyenComponents`

`BACSDirectDebitDetails`

robertdalmeida Jun 19, 2026 •

edited

Loading