Rename CardType to CardBrand for public alignment#2602
Merged
Conversation
erenbesel
added
the
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
ℹ️ No baseline data found for 'develop'.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive renaming of CardType to CardBrand across the codebase to resolve naming conflicts and clarify the domain model. The feedback highlights several documentation and parameter description comments that still refer to 'card type' instead of 'card brand' (specifically in FormCardNumberContainerItem.swift, CardSecurityCodeValidator.swift, CardSecurityCodeFormatter.swift, and InstallmentOptions.swift), as well as swapped documentation comments for types(forCardNumber:) and type(forCardNumber:) in CardBrandDetector.swift.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
erenbesel
dismissed
github-actions[bot]’s stale review
The base branch was changed.
Contributor
|
| ❇️ | 2 Additions |
| 🔀 | 12 Modifications |
| ❌ | 2 Removals |
Adyen
❇️ Added
public enum CardBrand: Swift.Codable, Swift.Equatable, Swift.Hashable, Swift.RawRepresentable {
case accel
case alphaBankBonusMasterCard
case alphaBankBonusVISA
case americanExpress
case argencard
case bcmc
case bijenkorfCard
case cabal
case carteBancaire
case cencosud
case chequeDejeneur
case chinaUnionPay
case codensa
case creditUnion24
case dankort
case dankortVISA
case diners
case discover
case elo
case forbrugsforeningen
case hiper
case hipercard
case jcb
case karenMillen
case kcp
case koreanLocalCard
case laser
case maestro
case maestroUK
case masterCard
case mir
case naranja
case netplus
case nyce
case oasis
case other(named: Swift.String)
case pulse
case shopping
case solo
case star
case troy
case uatp
case visa
case warehouse
public init(rawValue: Swift.String)
public typealias RawValue = Swift.String
public var rawValue: Swift.String { get }
}❌ Removed
public enum CardType: Swift.Codable, Swift.Equatable, Swift.Hashable, Swift.RawRepresentable {
case accel
case alphaBankBonusMasterCard
case alphaBankBonusVISA
case americanExpress
case argencard
case bcmc
case bijenkorfCard
case cabal
case carteBancaire
case cencosud
case chequeDejeneur
case chinaUnionPay
case codensa
case creditUnion24
case dankort
case dankortVISA
case diners
case discover
case elo
case forbrugsforeningen
case hiper
case hipercard
case jcb
case karenMillen
case kcp
case koreanLocalCard
case laser
case maestro
case maestroUK
case masterCard
case mir
case naranja
case netplus
case nyce
case oasis
case other(named: Swift.String)
case pulse
case shopping
case solo
case star
case troy
case uatp
case visa
case warehouse
public init(rawValue: Swift.String)
public typealias RawValue = Swift.String
public var rawValue: Swift.String { get }
}AnyCardPaymentMethod
🔀 Modified
// From
var brands: [Adyen.CardType] { get }
// To
var brands: [Adyen.CardBrand] { get }
/**
Changes:
- Modified type from `[Adyen.CardType]` to `[Adyen.CardBrand]`
*/BCMCPaymentMethod
🔀 Modified
// From
public var brands: [Adyen.CardType] { get }
// To
public var brands: [Adyen.CardBrand] { get }
/**
Changes:
- Modified type from `[Adyen.CardType]` to `[Adyen.CardBrand]`
*/CardPaymentMethod
🔀 Modified
// From
public let brands: [Adyen.CardType] { get }
// To
public let brands: [Adyen.CardBrand] { get }
/**
Changes:
- Modified type from `[Adyen.CardType]` to `[Adyen.CardBrand]`
*/InstallmentConfiguration
🔀 Modified
// From
public init(
cardBasedOptions: [Adyen.CardType : Adyen.InstallmentOptions],
defaultOptions: Adyen.InstallmentOptions,
showInstallmentAmount: Swift.Bool = false
)
// To
public init(
cardBasedOptions: [Adyen.CardBrand : Adyen.InstallmentOptions],
defaultOptions: Adyen.InstallmentOptions,
showInstallmentAmount: Swift.Bool = false
)
/**
Changes:
- Modified parameter `cardBasedOptions`: Changed type from `[Adyen.CardType : Adyen.InstallmentOptions]` to `[Adyen.CardBrand : Adyen.InstallmentOptions]`
*/// From
public init(
cardBasedOptions: [Adyen.CardType : Adyen.InstallmentOptions],
showInstallmentAmount: Swift.Bool = false
)
// To
public init(
cardBasedOptions: [Adyen.CardBrand : Adyen.InstallmentOptions],
showInstallmentAmount: Swift.Bool = false
)
/**
Changes:
- Modified parameter `cardBasedOptions`: Changed type from `[Adyen.CardType : Adyen.InstallmentOptions]` to `[Adyen.CardBrand : Adyen.InstallmentOptions]`
*/StoredCardPaymentMethod
🔀 Modified
// From
public let brand: Adyen.CardType { get }
// To
public let brand: Adyen.CardBrand { get }
/**
Changes:
- Modified type from `Adyen.CardType` to `Adyen.CardBrand`
*/// From
public var brands: [Adyen.CardType] { get }
// To
public var brands: [Adyen.CardBrand] { get }
/**
Changes:
- Modified type from `[Adyen.CardType]` to `[Adyen.CardBrand]`
*/AdyenCard
CardConfiguration
🔀 Modified
// From
public func supportedCardBrands(_ supportedCardBrands: [Adyen.CardType]?) -> AdyenCard.CardConfiguration
// To
public func supportedCardBrands(_ supportedCardBrands: [Adyen.CardBrand]?) -> AdyenCard.CardConfiguration
/**
Changes:
- Modified parameter `_`: Changed type from `[Adyen.CardType]?` to `[Adyen.CardBrand]?`
*/CardNumberFormatter
❇️ Added
final public var cardBrand: Adyen.CardBrand?❌ Removed
final public var cardType: Adyen.CardType?CardSecurityCodeFormatter
🔀 Modified
// From
public init(cardType: Adyen.CardType)
// To
public init(cardBrand: Adyen.CardBrand)
/**
Changes:
- Added parameter `cardBrand: Adyen.CardBrand`
- Removed parameter `cardType: Adyen.CardType`
*/// From
public init(publisher: Adyen.AdyenObservable<Adyen.CardType?>)
// To
public init(publisher: Adyen.AdyenObservable<Adyen.CardBrand?>)
/**
Changes:
- Modified parameter `publisher`: Changed type from `Adyen.AdyenObservable<Adyen.CardType?>` to `Adyen.AdyenObservable<Adyen.CardBrand?>`
*/CardSecurityCodeValidator
🔀 Modified
// From
public init(cardType: Adyen.CardType)
// To
public init(cardBrand: Adyen.CardBrand)
/**
Changes:
- Added parameter `cardBrand: Adyen.CardBrand`
- Removed parameter `cardType: Adyen.CardType`
*/// From
public init(publisher: Adyen.AdyenObservable<Adyen.CardType?>)
// To
public init(publisher: Adyen.AdyenObservable<Adyen.CardBrand?>)
/**
Changes:
- Modified parameter `publisher`: Changed type from `Adyen.AdyenObservable<Adyen.CardType?>` to `Adyen.AdyenObservable<Adyen.CardBrand?>`
*/Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay
robertdalmeida
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [Required]
Followup of aligning public API for card, binlookup related classes.
CardTyperenamed toCardBrand.Ticket [Optional]
COSDK-1243Checklist [Required]