[management] Code generation: update services and models - #2004
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces new models and API endpoints for managing donation campaigns and nonprofits within the Adyen Management API, alongside updates to payment methods (adding Cash App and associated payment methods), split configurations (adding DCC support), and terminal surcharge settings. The review feedback highlights two critical issues in the newly added 'DonationCampaignsApi.java': a compilation error caused by putting an enum directly into a 'Map<String, String>' path parameter, and a query parameter serialization bug where 'List.toString()' is used instead of joining the list elements.
227ac1d to
19c688d
Compare
b178a64 to
01d4c9d
Compare
01d4c9d to
d5043f9
Compare
|
jeandersonbc
left a comment
There was a problem hiding this comment.
changes look good. This PR contains mostly:
- breaking change: GenericPmWithTdiInfo -> CarnetInfo (PaumentMethodSetupinfo)
- feature: DonationCompaignsApi (and related models)
- minor updates: added fields, docs updates



This PR contains the automated changes for the
managementservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.Breaking Changes 🛠️
PaymentMethodSetupInfocarnetfield type changed fromGenericPmWithTdiInfotoCarnetInfo(getter/setter/builder signatures updated).New Features 💎
DonationCampaignsApiAdds donation campaign management, backed by the new campaignManagement and nonprofits endpoints:
createDonationCampaign—POST /companies/{companyId}/campaignManagementdeleteDonationCampaign—DELETE /companies/{companyId}/campaignManagement/{donationCampaignId}updateDonationCampaign—PATCH /companies/{companyId}/campaignManagement/{donationCampaignId}updateDonationCampaignStatus—POST /companies/{companyId}/campaignManagement/{donationCampaignId}/...listDonationCampaignsForAccountHolder—GET /companies/{companyId}/campaignManagementlistNonprofits / createNonprofit—POST /companies/{companyId}/nonprofitsCash App Pay supportCashAppUpdateInfoandCarnetInfo.UpdatePaymentMethodInfo— new cashapp field (CashAppUpdateInfo).PaymentMethodResponseandPaymentMethodSetupInfo— new cashapp enum value in payment method type.PaymentMethodList<AssociatedPaymentMethod>) — payment methods updated as part of an associated transition. New modelAssociatedPaymentMethod.Split configuration DCCSplitDcc.SplitConfigurationLogicandUpdateSplitConfigurationLogicRequest— new dcc field (SplitDcc).ScheduleTerminalActionsRequestActionDetails- Added discriminator (type) mappings for the action-details subtypesOther Changes