Skip to content

Compile Java 11 artifacts with --release - #2033

Merged
jeandersonbc merged 1 commit into
Adyen:mainfrom
gregjotau:build/use-java-release
Aug 11, 2026
Merged

jeandersonbc merged 1 commit into
Adyen:mainfrom
gregjotau:build/use-java-release

Conversation

@gregjotau

Copy link
Copy Markdown
Contributor

Closes #2032.

Replace the separate Java source/target settings with maven.compiler.release=11. This preserves the Java 11 bytecode and language baseline while also preventing accidental linkage to JDK APIs introduced after Java 11.

Verification:

  • mvn clean test -DskipITs
  • compiler reports [debug release 11]
  • the system modules ... -source 11 warning is gone
  • 617 tests pass, with 4 skipped

@gregjotau
gregjotau requested a review from a team as a code owner August 11, 2026 06:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Maven compiler configuration in pom.xml to use the <maven.compiler.release> property instead of the separate <maven.compiler.source> and <maven.compiler.target> properties. I have no further feedback to provide as there are no review comments.

@jeandersonbc jeandersonbc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gregjotau, thank you not only for raising the issue but providing this PR (along with the Maven reference). We appreciate your time checking it! I also just verified myself for the warning (mvn clean compile) and using the release option. Changes look good to me!

@jeandersonbc
jeandersonbc added this pull request to the merge queue Aug 11, 2026
Merged via the queue into Adyen:main with commit 370ae78 Aug 11, 2026
6 checks passed
@gregjotau
gregjotau deleted the build/use-java-release branch August 11, 2026 08:42
@gregjotau

Copy link
Copy Markdown
Contributor Author

Great, we integrate Adyen into reai.no (accounting system) now and we want to contribute and improve all third party libraries we use.

Especially important for us that dependencies are modularised in such a way that we bring in as little surface as possible :)

thanks @jeandersonbc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile Java 11 artifacts with --release

2 participants