feat(models): show the UVT cap on locked rows, not just usable ones - #67
Merged
Conversation
A locked row answered "what unlocks it" and not "what you get for unlocking it" — so the one number that argues for upgrading was missing from the only row where the upgrade decision happens. The cause is that `monthly_uvt_cap` answers for the CALLER's tier. On a locked row that is null by construction: the caller's tier does not include the model, so it has no cap on it. The renderer then fell back to showing only the gate. Server-side companion adds `unlock_uvt_cap` — the ceiling the model carries on `tier_min`. This reads it and renders both, joined by a separator: before opus 1M needs pro after opus 1M needs pro · cap 60k Available rows are unchanged and still show the caller's own cap. The field is optional on CatalogItem so an older server that does not send it degrades to exactly the previous output rather than rendering "cap undefined". tsc clean; model_picker suite 14 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A locked row in
aether modelsanswered "what unlocks it" and not "what you get for unlocking it" — so the one number that argues for upgrading was missing from the only row where the upgrade decision happens.Why it was missing
monthly_uvt_capanswers for the caller's tier. On a locked row it isnullby construction — the caller's tier doesn't include the model, so it has no cap on it. The renderer then fell back to showing the gate alone.The server-side companion adds
unlock_uvt_cap: the ceiling the model carries ontier_min. This PR reads it and renders both.Compatibility
unlock_uvt_capis optional onCatalogItem, so an older server that doesn't send it degrades to exactly the previous output rather than printingcap undefined. Available rows are untouched and still show the caller's own cap.Verification
tsc --noEmitcleanmodel_pickersuite: 14 pass, 0 failnpm testexits 0Depends on
The AETHER-CLOUD change that emits
unlock_uvt_capfromlib/model_catalog.py. This PR is safe to merge first — without the field, output is unchanged from today.