Improve game compatibility#60
Open
AetiasHax wants to merge 48 commits into
Open
Conversation
In some games these registers are used for local variables while not being callee-saved. If those local variables also happen to be used without an initial value, then dsd would assume the instruction is illegal. It is undefined behavior however, but not illegal.
It seems older versions of the compiler doesn't use `add pc, {offset}` for the branching instruction
…nction call relocations
The base address of a static overlay does not come directly after the end address of another overlay. Previously, we did not allow such gaps between overlays. But since some games have gaps, those overlays are now allowed and will be placed at an exact address by the LCF.
There was a duplicate error message since I copied over data analysis code from CLI to library
Some dsd projects complain here when checking locations of external labels, but label symbols aren't imported by SymbolMapsExt::from_object so there's no reason to check them
It was moved from CLI to library and that changed which error type we want to look for
By default, `object::Object::symbol_by_name` scans through all symbols until it finds a match. `dsd rom config` uses it to find section addresses for each module, so it ends up doing a lot of passes through all symbols. Instead, we now pass through all symbols *once*, registering them in a HashMap so they can be queried much quicker later.
Some games have gaps between each overlay group, which seems to mean that they were manually placed at arbitrary addresses. Rather than add support for this in the current algorithm, I rewrote and shortened it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tons of changes to function analysis and relocation analysis which makes more games compatible with
dsd init, either by fixing errors or by making the generated dsd configs more sensible.The generated output of
dsd initwill be slightly different compared to already established projects, but it's nothing major.