Handle additional error case for truncated or absent multiboot signature#24
Merged
Conversation
Owner
|
Thanks for the fix! I can see the error happening on retail ROMs as well, so it only makes sense to treat the multiboot signature as absent in this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single line PR that adds a match arm for
RawMultibootSignatureError::DataTooSmallerrors. I had some issues with extraction failing for ROMs built by ndstool. It's likely ndstool destroys the multiboot signature. I think it's reasonable to continue extraction here especially since the other error types do the same.