Repository navigation
fix: capture browser exceptions and drop in-app noise - #150
Merged
Merged
Conversation
The site recorded tens of thousands of events and zero exceptions. Turn exception capture on, and drop Script error, Zalo, Facebook in-app, and extension stacks before they are sent.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
automerge:blocked
Contributor
Auto-merge policy — LIVE⛔ Blocked
Human review is required; auto-merge was not requested.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Seven days of product analytics showed about 60,000 events and 2,300 users, and zero
$exceptionevents. The browser SDK was not capturing exceptions, so a broken page would not show up.This turns
capture_exceptionson.before_senddrops noise before it is sent:Script error., Zalo's injected script, Facebook in-apppostMessagefailures, extension disconnects, and stacks whose every frame is the Facebook in-app browser or a browser extension. An exception that also has an app frame is kept.No PostHog project setting is changed.
Test
npx tsx --test scripts/posthog-noise.test.ts— 5 passed.