Repository navigation
feat: say what a program page apply button pays - #151
Merged
Merged
Conversation
The program pages asked people to apply or join without the commission. The button now says Apply and earn, plus the rate when that stays within four words, and records the click as cta_oa_program.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
automerge:blocked
Contributor
Auto-merge policy — LIVE⛔ Blocked
Human review is required; auto-merge was not requested.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Program pages said "Apply to program" and "Join Program". The signed label is "Apply & earn {commission}%": no em dash, at most four words.
Both buttons on
/programs/{slug}now use that label. A percentage renders as "Apply & earn 20%". A flat fee renders as "Apply & earn $36" and does not gain a percent sign. An unknown or long rate stays "Apply & earn".Clicking either button still records
outbound_clickand also recordscta_oa_program.Test
npx tsx --test scripts/apply-cta.test.ts— 3 passed.