Fix DDOP filename creation.#62
Merged
Merged
Conversation
gunicsba
commented
Jun 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address issue #61 by preventing invalid characters from ending up in the generated DDOP filename (derived from the implement’s localization label), which can prevent DDOP persistence/loading.
Changes:
- Updates localization label trimming logic used when constructing the DDOP filename.
- Adds a Task Controller server callback to log the client-reported TC version.
- Updates build metadata (project version) and adjusts CMake dependency/policy handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/task_controller.cpp | Updates DDOP filename label trimming and adds on_client_version_received logging implementation. |
| include/task_controller.hpp | Declares on_client_version_received(...) override on MyTCServer. |
| CMakeLists.txt | Bumps version, switches/pins AgIsoStack++ source, and scopes policy behavior around git_version FetchContent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pat-I
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would fix the issue we see in ticket #61