Skip to content

category: fix enterprise and redirects issue #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DnD-Hellion wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

category: fix enterprise and redirects issue #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions app/code/community/Pimgento/Api/Model/Job/Category.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,10 +498,8 @@ public function setUrlKey($task)
$isMagentoEnterprise = Mage::getEdition() === Mage::EDITION_ENTERPRISE;

if ($isMagentoEnterprise) {
/** @var Mage_Core_Model_Factory $factory */
$factory = Mage::getSingleton('core/factory');
/** @var Enterprise_Catalog_Model_Category_Redirect $redirect */
$redirect = $factory->getModel('enterprise_catalog/category_redirect');
$redirect = Mage::getModel('enterprise_catalog/category_redirect');
}

/**
Expand Down Expand Up @@ -553,9 +551,9 @@ public function setUrlKey($task)
/** @var string $table */
$table = $resourceEntities->getValueTable('catalog/category', $urlAttribute['backend_type']);

if (!$isMagentoEnterprise) {
$adapter->insertOnDuplicate($table, $values);
$adapter->insertOnDuplicate($table, $values);

if (!$isMagentoEnterprise) {
continue;
}

Expand All @@ -574,15 +572,18 @@ public function setUrlKey($task)
)->limit(1)
);

if (empty($currentUrl) || $currentUrl != $newUrlKey) {
if (empty($currentUrl) || $currentUrl === $newUrlKey) {
continue;
}

$categorySingleton->setId($row['entity_id']);

$adapter->dropTemporaryTable(Enterprise_Catalog_Model_Category_Redirect::TMP_TABLE_NAME);

$redirect->saveCustomRedirects($categorySingleton, $storeValue['store_id']);

// Force new connection in order to get temporary table and drop it
/** @var Varien_Db_Adapter_Interface $dropAdapter */
$dropAdapter = $resourceEntities->getReadConnection();
$dropAdapter->dropTemporaryTable(Enterprise_Catalog_Model_Category_Redirect::TMP_TABLE_NAME);
}
}
}
Expand Down