54 desktop app - #58
Merged
Merged
Conversation
Code review flagged agentfm-go/dist/* (8 platform binaries + checksums), the dev agentfm binary, and committed .pyc files as tracked repo bloat. Untrack them (files stay on disk) and add .gitignore rules — build artifacts ship via GitHub Releases, not VCS. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- New Getting Started tab: prereqs (Podman/Ollama/CLI) + copy-paste worker commands for running public and private agents, framed around the app being the Boss that dispatches to CLI-run workers. - Remove 'last seen · Xs ago' from the peer-history Status field (just online/offline now). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a grouped 'every flag' table (agent, limits, network, API gateway, trust & observability) with descriptions + defaults, list the -mode values, and enrich the public/private worker samples with -desc, -capability, -author, and -maxtasks/-maxcpu/-maxgpu. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ntfm -mode relay Two relay implementations (the cmd/relay lighthouse and a stripped-down agentfm -mode relay) was confusing and the built-in one silently lacked the archive ledger + infinite limits + telemetry routing. Consolidate: - host.go: relay branch now uses EnableRelayService(WithInfiniteLimits()) + ForceReachabilityPublic + EnableNATService; GossipSub gets PeerExchange. - cmd/agentfm/relay.go (new): full-featured runRelayMode — telemetry subscribe+drain and an archive ledger at ~/.agentfm/relay_ledger.db that serves catch-up, exactly what the standalone binary did. - -identity now applies to relay mode, defaulting to a stable ~/.agentfm/relay_identity.key (cwd-independent). - Delete cmd/relay/; release.sh builds only agentfm; docs updated. Verified live: worker visible through the relay, and a fresh boss caught up the full ledger from the relay's archive. Full -race suite green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
README listed only Worker/Boss/Relay; add a lean one-line Witness entry (ledger-only replica for offline catch-up) so the role is discoverable on the main page. Getting Started already documents it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Each -mode (worker/api/boss/relay/witness/genkey) has its own parameters, so document it that way instead of one flat flag list: - Getting Started: replace the category-grouped flag tables with a 'Modes & parameters' section — per-mode purpose + copyable example + that mode's flags, then a shared 'common to all P2P modes' table. - README: add a 'Modes' table with a one-line example per mode. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The packaged app resolves its backend as agentfm-${process.platform}-${process.arch}
(e.g. agentfm-darwin-x64 on Intel, agentfm-win32-x64 on Windows), but
build-binaries.sh emitted Go's GOARCH/GOOS names (agentfm-darwin-amd64,
agentfm-windows-amd64). arm64 happened to match; Intel/Windows installs
could not find the backend ('binary not found at .../bin/agentfm-darwin-x64').
Map GOOS/GOARCH -> Node platform/arch when naming outputs; add a 'mac' arg
for macOS-only builds.
Also rebuild the app icon on a near-black rounded tile — the logo's 'AGENT'
wordmark is white and was invisible on the old white background.
Verified: packaged arm64 app spawns its bundled backend (200 /health); the
x64 .app now carries a genuine x86_64 agentfm-darwin-x64 at the same path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Witness is advanced/optional — the relay already persists the ledger, so mentioning witness up front confused newcomers. Remove it from the README roles list + Modes table and the Getting Started modes section. Keep it documented in the deep reference (docs/cli.md, docs/trust.md) since -mode witness is still a real command shown by 'agentfm --help'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.