fix: make native probe installer progress safe under sh - #106
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe installer now uses ChangesInstaller validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the shell at dawn Comment |
|
Preview deployed!
This is a Cloudflare Workers preview version of this PR's build. |
The native probe installer runs with
set -u; on affected shells the ellipsis immediately after$platformcan be interpreted as part of the variable name. Delimit it as${platform}so installation reaches the binary download reliably.Validation
/bin/shparsing/help and the exact platform progress line underset -u.This is the installer companion to the sessions onboarding changes. Unrelated marketing/Flows edits are excluded.
Agent session:
codex://threads/01a0bbe4-973f-7a81-928e-4ea6b005be98.Companion PRs