Skip to content

fix: make native probe installer progress safe under sh - #106

Merged
willwashburn merged 1 commit into
mainfrom
codex/sessions-experience
Sep 21, 2026
Merged

willwashburn merged 1 commit into
mainfrom
codex/sessions-experience

Conversation

@willwashburn

@willwashburn willwashburn commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

The native probe installer runs with set -u; on affected shells the ellipsis immediately after $platform can be interpreted as part of the variable name. Delimit it as ${platform} so installation reaches the binary download reliably.

Validation

  • Installer regression suite: 2 tests passed, covering /bin/sh parsing/help and the exact platform progress line under set -u.
  • Local full-stack smoke test successfully downloaded and installed the native probe, authorized the device, uploaded synthetic history, and read the resulting session and assistant response in Cloud.

This is the installer companion to the sessions onboarding changes. Unrelated marketing/Flows edits are excluded.

Agent session: codex://threads/01a0bbe4-973f-7a81-928e-4ea6b005be98.

Companion PRs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-20T03:28:58.058351Z ff6c8eb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 169262f3-7ec2-4ba6-ab03-7cd73d86c5c2

📥 Commits

Reviewing files that changed from the base of the PR and between 9aa005b and ff6c8eb.

📒 Files selected for processing (2)
  • web/lib/test/probe-install.test.ts
  • web/public/install.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The installer now uses ${platform} in its progress message. New tests validate shell syntax, help output, and progress output under set -u.

Changes

Installer validation

Layer / File(s) Summary
Installer output and validation
web/public/install.sh, web/lib/test/probe-install.test.ts
The progress message uses ${platform}. Tests validate POSIX syntax, --help output, and darwin-arm64… progress output under set -u.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description accurately explains the ${platform} fix, the shell parsing issue, and the validation results.
Title check ✅ Passed The title clearly identifies the native probe installer fix and its shell-safety purpose.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the shell at dawn
${platform} hops along
Help text shines with steady cheer
Darwin progress prints clear
Safe under set -u
Tests bloom in green anew

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Preview deployed!

Environment URL
Web https://495a9402-agentrelay-web.agent-workforce.workers.dev

This is a Cloudflare Workers preview version of this PR's build.

@willwashburn
willwashburn merged commit 6547e37 into main Sep 21, 2026
5 checks passed
@willwashburn
willwashburn deleted the codex/sessions-experience branch September 21, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant