Skip to content

Fix software-garden PR ticket metadata - #109

Merged
kjgbot merged 2 commits into
mainfrom
codex/garden-pr-metadata-0920
Sep 20, 2026
Merged

kjgbot merged 2 commits into
mainfrom
codex/garden-pr-metadata-0920

Conversation

@kjgbot

@kjgbot kjgbot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • carry Cloud's normalized identifier and url fields into generated software-factory issue types
  • derive a whitespace-normalized, Unicode-safe bounded PR title from the ticket title
  • append one deterministic provider reference (Fixes #<number> for GitHub), then fail closed on bad final metadata before push or PR/MR creation
  • require local GitHub kits to collect the real issue number while keeping Markdown and non-GitHub runs number-free
  • cover generated source, hosted/local opening paths, body deduplication, and refusal cases

Verification

  • cd web && ./node_modules/.bin/tsc --noEmit — passed
  • cd web && ./node_modules/.bin/vitest run -t '^(?!.*runs the resolved default end to end).*$' --reporter=dot — 20 files passed; 211 tests passed, 1 intentionally skipped
  • cd web && ./node_modules/.bin/vitest run lib/test/flow-local.test.ts --reporter=dot — 38 tests passed

One pre-existing shell-suite case was run separately and remains an environment baseline failure: FLOW_CHECK_RUN_COMMAND > runs the resolved default end to end, and still fails a failing suite performs temporary package installs and took about 81 seconds while retaining a fixed 5-second Vitest timeout. It reproduces alone and does not exercise this change.

No Cloud repository change is needed: the generated contract now exposes the already-normalized metadata described by FlowIssue.


Note

Medium Risk
Changes the publish gate (title, GitHub linking, push/PR ordering) for all generated software-factory workflows; behavior is heavily tested but mistakes could block PR creation or mis-link issues.

Overview
Software factory flows now derive pull request titles from the ticket (whitespace-normalized, capped at 240 Unicode code points) instead of the generic "Software factory change", and stop before any agent work when the title is empty/placeholder or a GitHub ticket lacks a normalized #<number> identifier.

Generated flows add identifier and url on Issue, build a deterministic closing line (Fixes #… on GitHub, Closes #… on GitLab when applicable, otherwise Ticket: …), append it once to .relayflow/pr-body.md, then run a fail-closed shell validation immediately before push/gh pr create. Invalid metadata ends the run with needs_human without opening a PR (push is deferred until validation passes on the happy path).

Local GitHub kits prefill issue.identifier as empty, extend relay-preflight to require #<number> (prompt on a TTY, hard fail otherwise), and only prompt for title/body when the placeholder body is still present.

Reviewed by Cursor Bugbot for commit 0e7ccbf. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f4f14d7c-e640-4009-9c63-d50236d4c290


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployed!

Environment URL
Web https://db2b1a2c-agentrelay-web.agent-workforce.workers.dev

This is a Cloudflare Workers preview version of this PR's build.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 93d2614. Configure here.

Comment thread web/lib/flow-workflows.ts Outdated
@kjgbot
kjgbot force-pushed the codex/garden-pr-metadata-0920 branch from 93d2614 to 0e7ccbf Compare September 20, 2026 22:03
@kjgbot
kjgbot merged commit 9565054 into main Sep 20, 2026
5 checks passed
@kjgbot
kjgbot deleted the codex/garden-pr-metadata-0920 branch September 20, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant