Fix software-garden PR ticket metadata - #109
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployed!
This is a Cloudflare Workers preview version of this PR's build. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 93d2614. Configure here.
93d2614 to
0e7ccbf
Compare

Summary
identifierandurlfields into generated software-factory issue typesFixes #<number>for GitHub), then fail closed on bad final metadata before push or PR/MR creationVerification
cd web && ./node_modules/.bin/tsc --noEmit— passedcd web && ./node_modules/.bin/vitest run -t '^(?!.*runs the resolved default end to end).*$' --reporter=dot— 20 files passed; 211 tests passed, 1 intentionally skippedcd web && ./node_modules/.bin/vitest run lib/test/flow-local.test.ts --reporter=dot— 38 tests passedOne pre-existing shell-suite case was run separately and remains an environment baseline failure:
FLOW_CHECK_RUN_COMMAND > runs the resolved default end to end, and still fails a failing suiteperforms temporary package installs and took about 81 seconds while retaining a fixed 5-second Vitest timeout. It reproduces alone and does not exercise this change.No Cloud repository change is needed: the generated contract now exposes the already-normalized metadata described by
FlowIssue.Note
Medium Risk
Changes the publish gate (title, GitHub linking, push/PR ordering) for all generated software-factory workflows; behavior is heavily tested but mistakes could block PR creation or mis-link issues.
Overview
Software factory flows now derive pull request titles from the ticket (whitespace-normalized, capped at 240 Unicode code points) instead of the generic
"Software factory change", and stop before any agent work when the title is empty/placeholder or a GitHub ticket lacks a normalized#<number>identifier.Generated flows add
identifierandurlonIssue, build a deterministic closing line (Fixes #…on GitHub,Closes #…on GitLab when applicable, otherwiseTicket: …), append it once to.relayflow/pr-body.md, then run a fail-closed shell validation immediately before push/gh pr create. Invalid metadata ends the run withneeds_humanwithout opening a PR (push is deferred until validation passes on the happy path).Local GitHub kits prefill
issue.identifieras empty, extendrelay-preflightto require#<number>(prompt on a TTY, hard fail otherwise), and only prompt for title/body when the placeholder body is still present.Reviewed by Cursor Bugbot for commit 0e7ccbf. Bugbot is set up for automated code reviews on this repo. Configure here.