Repository navigation
Fix router deploy: drop unresolvable WEBHOOK_WORKER service binding - #3
Conversation
The deploy failed: a service binding to script `webhook-worker` returns "Worker not found" (code 10143) — cloud names/exposes that worker differently and configures webhook offload via the WEBHOOK_WORKER_ORIGIN *.workers.dev URL, not a service binding. Drop the binding so the router deploys; webhook offload (only active when the ROUTER_CONFIG WEBHOOK_ORIGIN flag is "worker") is wired back before the apex cutover. Also fix a missed @agentworkforce/cloud label in the README diagram. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe router's ChangesRouter webhook routing config and docs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployed!
This is a Cloudflare Workers preview version of this PR's build. |
The ROUTER_CONFIG WEBHOOK_ORIGIN flag is 'worker', so the router forwards /api/v1/webhooks/* to the dedicated webhook Worker. Set the URL (read from the live router) since the worker's SST-hashed script name isn't service-bindable.
The merged router deploy failed with
Service binding 'WEBHOOK_WORKER' references Worker 'webhook-worker' which was not found(code 10143). That binding was an addition in #2 — cloud's router configures webhook offload via theWEBHOOK_WORKER_ORIGINURL, not a service binding, and the webhook Worker isn't resolvable under that script name. Everything else (incl.cloud-web-worker) validated fine.Drop the binding so
router-next.agentrelay.comdeploys. Webhook offload only matters when theROUTER_CONFIGWEBHOOK_ORIGINflag isworker; it'll be wired back (via the URL) before the apex cutover. Also corrects a missed@agentworkforce/cloudlabel in the README diagram.Summary by cubic
Fix router deploy by removing the unresolvable
WEBHOOK_WORKERbinding and wiringWEBHOOK_WORKER_ORIGINto the prod webhook Worker URL. The router now deploys cleanly and offloads/api/v1/webhooks/*via the URL whenROUTER_CONFIG.WEBHOOK_ORIGINisworker.router/wrangler.jsonc: droppedWEBHOOK_WORKER; setWEBHOOK_WORKER_ORIGINto the live workers.dev URL to resolve 10143 and keep webhook offload working.@agentworkforce/agentrelay.com.Written for commit f88099a. Summary will update on new commits.