chore(ci): park the review swarm until it is a RelayFlow v2 flow - #471
AgentRelayBot wants to merge 1 commit into
Conversation
The `review` check failed on every open PR (#451, #455, #441) in the swarm's own posting step, not on a code verdict: Fetching patch for run <uuid>... No changes to sync — the workflow did not modify any files. ##[error]Process completed with exit code 1 Reproducible across reruns with fresh swarm ids. A check that fails on every PR can neither approve nor block, so it was merged over in practice; leaving it on `pull_request` only taught people to ignore a red check. That failure is the v1 design showing through: the gate assumes a review's product is a patch to sync back, so a review that correctly proposes no code change reads as a failure. It also drives RelayFlow v1 via `agent-relay cloud run`, the surface relay#1783 deprecated. Both point at the v2 port in #470 rather than a repair here. `workflow_dispatch` is a parking trigger, not a working manual path — every step reads `github.event.pull_request.*`. Wiring that up is deliberately left undone; it is work on the surface #470 retires. The wrapper guard stays on `pull_request_target` and keeps passing, so a candidate still cannot weaken the gate that will judge it once it returns. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Session-Id: d458bd97-53d8-4f02-be9c-48b67b93c916
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — this cannot merge, and it shouldn't. The
The swarm has instead been stopped at the platform level: Same outcome — no The tradeoff is that the disabled state now lives in repo settings rather than in the tree, so it is invisible to someone reading the workflow. #470 carries the reasoning, and re-enabling is part of its scope. 🤖 Generated with Claude Code |
Stops
review-swarm.ymlrunning onpull_request. Tracked for the real fix in #470.Why
The
reviewcheck failed on every open PR — #451, #455, #441 all identical, in the swarm's own posting step rather than on a code verdict:Reproducible across reruns with fresh swarm ids, so not flaky infrastructure. A check that fails on every PR carries no signal — it can neither approve nor block, and in practice it gets merged over. Leaving it red only trains people to ignore a red check.
The failure is the v1 design showing through: the gate assumes a review's product is a patch to sync back, so a review that correctly proposes no code change reads as a failure. It also drives RelayFlow v1 (
agent-relay cloud run ... --sync-code), the surface relay#1783 deprecated. Both argue for the v2 port rather than a repair here.What this does not do
workflow_dispatchis a parking trigger, not a working manual path — nine steps readgithub.event.pull_request.*, empty off apull_requestevent. Wiring that up is deliberately left undone: it is work spent on the surface #470 retires. The comment in the file says so, so nobody dispatches it expecting a run.The wrapper guard (
review-swarm-wrapper-guard.yml) is untouched and still runs onpull_request_targetreading from base, so a candidate PR still cannot weaken the gate that will judge it once it returns.🤖 Generated with Claude Code
Note
Low Risk
CI-only change that stops a always-failing check; no application or security logic is modified.
Overview
Parks the Review swarm CI check so it no longer runs on every pull request.
The
review-swarm.ymltrigger moves frompull_requesttoworkflow_dispatchonly, with an in-file comment documenting why: the v1 gate failed on every PR when no patch was synced, drove deprecated RelayFlow v1, and a manual dispatch path is intentionally not wired (steps still expectpull_requestcontext). The real fix is tracked in #470; the wrapper guard workflow is unchanged.Reviewed by Cursor Bugbot for commit 6111612. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
The
reviewcheck was failing on every open PR in its own posting step (No changes to sync), so this parksreview-swarm.ymlinstead of repairing the v1 design. It no longer runs onpull_request; the real fix is the RelayFlow v2 port tracked in #470.workflow_dispatch, which is a parking trigger only: the steps still readpull_requestevent data, so a manual dispatch will not run the swarm.pull_request_target, so the base branch keeps its protection while the workflow is parked.Written for commit 6111612. Summary will update on new commits.