Repository navigation
fix(sdk): persist Codex step history - #617
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
maintainability lens — UNCLEARYou've hit your weekly limit · resets Oct 7 at 3am (America/Los_Angeles) |
Contributor
Author
history lens — PASSBlockers: none. Concerns
Notes
REVIEW_PASSED |
Contributor
Author
structure lens — UNCLEARError: Error from provider (Console): OpenCode's free tier can only be used from within OpenCode |
Contributor
Author
|
🎯 review-swarm: FAILED (M:unclear H:pass S:unclear) Lens transcripts posted as sibling comments above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentandllmsteps persist their native Codex sessionsWhy
Cloud teardown now uses the released headless Relayhistory probe successfully, but a real hosted smoke run completed with
exitReason=drained,sessionsCaptured=0, andacknowledgedRecords=0. The released Flow runtime launches real Codex steps with--ephemeral, so Codex deliberately writes no session underCODEX_HOME/~/.codexfor the teardown uploader to capture.Verification
The monolithic macOS suite was also attempted. Its adapter/build gates passed, then unrelated Linux-only isolation tests and widespread 5-second parallel timeouts failed; focused and affected suites above are green.
Note
Medium Risk
Changes the Codex CLI contract for all agent/llm steps (persistent sessions on disk), which affects hosted history capture but is intentional and narrowly scoped with test pins.
Overview
Fixes hosted runs reporting zero captured Codex sessions by stopping use of
--ephemeralon real workflow invocations.Agent and LLM Codex
execargv no longer include--ephemeral, so steps can write native session data underCODEX_HOME/~/.codexfor Relayflow teardown to flush into Relayhistory. Model readiness probes still use--ephemeralbecause they are diagnostics, not steps.Adapter tests,
cli-adapterexpectations, and the live-kernel Codex argv contract are updated to assert the persistent argv shape (no--ephemeralon agent/llm; still present on probes).Reviewed by Cursor Bugbot for commit e310a18. Bugbot is set up for automated code reviews on this repo. Configure here.