Skip to content

chore: add installed slack-comms persona - #151

Merged
kjgbot merged 3 commits into
mainfrom
persona/add-slack-comms
Jun 7, 2026
Merged

kjgbot merged 3 commits into
mainfrom
persona/add-slack-comms

Conversation

@kjgbot

@kjgbot kjgbot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

What

Adds the slack-comms persona to pear's tracked personas (.agentworkforce/workforce/personas/), matching the existing tracked personas (autonomous-actor, pear-auth-specialist, settings-panel-hero).

How it got here

Installed via agentworkforce install @agentworkforce/persona-slack-comms (published from AgentWorkforce/workforce#213). This PR commits the installed artifacts so the persona is version-controlled in pear (and survives respawn).

Contents

  • slack-comms.json — harness claude / model claude-sonnet-4-6; 5 skills (setting-up-relayfile, workspace-layout, writeback-as-files, orchestrating-agent-relay, persona-relayfile-mount).
  • __assets/slack-comms/slack-comms.md — operating spec: comms-only liaison, threaded brief-yet-detailed replies, <@ID> mentions, writeback flush verification, OOB-read drop-guard, and stay-in-lane discipline (route issues to the coordinator; don't diagnose/fix/task workers directly).

🤖 Generated with Claude Code

@codeant-ai

codeant-ai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@kjgbot, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 minute and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f1b955fb-07d4-47f1-9592-52e0dd83451a

📥 Commits

Reviewing files that changed from the base of the PR and between a1281aa and ba7f283.

📒 Files selected for processing (3)
  • .agentworkforce/workforce/personas/__assets/slack-comms/slack-comms.md
  • .agentworkforce/workforce/personas/slack-comms.json
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch persona/add-slack-comms

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the slack-comms persona, adding its configuration file (slack-comms.json) and operational guidelines (slack-comms.md). The persona serves as a comms-only Slack liaison that handles inbound and outbound messages via relayfile writebacks. Feedback on the pull request points out an error in the documented path for threaded replies, which should use threads instead of messages to align with the writeback command root matching logic.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +40 to +41
- **Threaded reply** (the default): write to
`messages/<thread_ts>/replies/<name>.json` and include a `thread_ts` field.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The threaded reply path is described as messages/<thread_ts>/replies/<name>.json. However, according to the writeback command root matching logic in src/main/slack-writeback-command-roots.ts, the expected path segment for threads is threads, not messages (i.e., threads/<thread_ts>/replies/<name>.json). Writing to messages/.../replies/... will fail to match the writeback command root and won't be processed correctly.

Suggested change
- **Threaded reply** (the default): write to
`messages/<thread_ts>/replies/<name>.json` and include a `thread_ts` field.
- **Threaded reply** (the default): write to
`threads/<thread_ts>/replies/<name>.json` and include a `thread_ts` field.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

"optional": true
}
},
"agentsMd": "__assets/slack-comms/slack-comms.md"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 agentsMd field vs claudeMdContent pattern

The new persona uses "agentsMd": "__assets/slack-comms/slack-comms.md" (a file-path reference) while the existing autonomous-actor.json uses claudeMdContent with inline content. The spec document at docs/specs/workforce-persona-agents.md:38 mentions claudeMdContent / agentsMdContent as known field names. agentsMd appears to be a file-path variant (as opposed to inline agentsMdContent). Since the agentworkforce CLI (^3.0.50) processes these persona definitions externally, and the referenced file exists at the correct relative path, this is likely a supported alternate form. Cannot fully verify without access to the agentworkforce CLI's schema documentation.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +8 to +9
"integrations": {
"slack": {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 integrations field is unique to this persona

The "integrations": { "slack": {} } field at line 8-9 does not appear in any other persona JSON in this repository. The other personas (autonomous-actor, pear-auth-specialist, settings-panel-hero) don't declare integrations. This is likely a valid field that tells the agentworkforce CLI to provision the Slack integration for this persona, but it's a pattern not previously seen in this repo's persona files. If the agentworkforce CLI doesn't recognize this field, it would be silently ignored rather than causing an error.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

agent-relay-code Bot added a commit that referenced this pull request Jun 7, 2026
@codeant-ai

codeant-ai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@agent-relay-code

Copy link
Copy Markdown
Contributor

✅ pr-reviewer applied fixes — committed and pushed f439760 to this PR. The notes below describe what changed.

Implemented the PR fixes in the checkout:

  • Fixed Slack threaded writeback docs to use threads/<thread_ts>/replies/<name>.json.
  • Changed slack-comms.json from agentsMd to claudeMd so the Claude persona actually loads the operating manual as CLAUDE.md.
  • Kept integrations.slack after validating it against @agentworkforce/persona-kit; it parses as a valid deployer-user Slack integration.

Validated locally:

  • npx --yes agentworkforce show slack-comms --json
  • npx --yes agentworkforce agent slack-comms --dry-run
  • npm run verify:mcp-resources-drift
  • npm test
  • npm run build

Bot comments reviewed from PR #151: Gemini’s path issue and Devin’s sidecar concern are addressed; Devin’s integrations concern was validated as supported. Current PR metadata showed mergeable true, and current remote checks were green, but these local edits still need the harness/cloud commit and the resulting checks before the PR can be considered ready.

@codeant-ai

codeant-ai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

kjgbot and others added 3 commits June 7, 2026 21:03
Commits the slack-comms persona installed via
`agentworkforce install @agentworkforce/persona-slack-comms`, matching
the other tracked personas in this directory. Comms-only Slack liaison
(Sonnet), 5 relayfile/relay skills, stay-in-lane operating spec.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
So `npm run personas:refresh` pulls upstream updates to the published
@agentworkforce/persona-slack-comms pack (mirrors cloud's personas:refresh
pattern), not just autonomous-actor.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@kjgbot
kjgbot force-pushed the persona/add-slack-comms branch from 099827b to ba7f283 Compare June 7, 2026 19:03
@codeant-ai

codeant-ai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@kjgbot
kjgbot merged commit 6721107 into main Jun 7, 2026
3 checks passed
@kjgbot
kjgbot deleted the persona/add-slack-comms branch June 7, 2026 19:05
@agent-relay-code

Copy link
Copy Markdown
Contributor

✅ pr-reviewer applied fixes — committed and pushed 31c572d to this PR. The notes below describe what changed.

Reviewed PR #151 against the provided diff and current checkout.

Fixed:

  • Refreshed slack-comms from the published persona pack via npm run personas:refresh, which corrected the manifest from claudeMd to agentsMd and updated the kickoff description to reference AGENTS.md.
  • Updated .agentworkforce/README.md so package-sourced persona guidance includes both autonomous-actor and slack-comms.

Verified locally:

  • npm run personas:refresh
  • npx --yes agentworkforce show slack-comms --json
  • npm run verify:mcp-resources-drift
  • npm test
  • npx vitest run src/main/broker.test.ts
  • npm run build

I did not print READY because I cannot verify live GitHub CI status or mergeability from here under the no-gh/no-git constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant