Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/pr-reviewer-substance-failing-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: pr-reviewer substance failing check

on:
pull_request:
branches:
- main

jobs:
forced-failure:
runs-on: ubuntu-latest
steps:
- name: fail for pr-reviewer substance test
run: |
echo "substance-test-2 forced CI failure"
exit 1
2 changes: 2 additions & 0 deletions docs/pr-reviewer-substance-conflict-sync.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This file exists only to trigger a pull_request.synchronize event while PR #60
is intentionally merge-conflicting against its temporary probe base branch.
2 changes: 2 additions & 0 deletions docs/pr-reviewer-substance-serialized-trigger.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This external commit is the serialized follow-up trigger after the prior
pr-reviewer run withheld changes because the branch moved mid-review.
8 changes: 8 additions & 0 deletions src/main/pr-reviewer-substance-probe.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export interface ProbeProfile {
displayName?: string
}

export function formatProbeGreeting(profile: ProbeProfile | null): string {
const normalized = profile ?? {}
return `Hello, ${normalized.displayName!.trim()}`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[substance-test-1 bot-feedback] This line introduces a null-deref: normalized.displayName can be undefined when profile is null or lacks displayName, so the non-null assertion will still crash at runtime. Please guard it or provide a safe fallback.

}